Repository navigation
Conversation
Refs #217. infoOf and insMetaOf are called by almost every wrapper of SelectQuery[T] and InsertQuery[T]; inlined, each wrapper carries its own copy of the field loads.
…lpers Refs #217. Every method of a generic type, exported or not, gets a wrapper for each instantiated type and its pointer. The renderer's dynamic checks (render, renderBare, needsParens, hasLock, selectArity) now share one method, selectView, and rows, runPreloads and qualifier are plain functions.
Refs #217. Run 44064173689 measured 5809780 KiB (5673 MiB), was 6338328 KiB. Budget is that plus about 15 percent, rounded.
…asurement Refs #217. The same code measured 5809780 KiB and 6318800 KiB on two runs, so a 15 percent margin on the lower one would flake. Run 44066175274: 6318800 KiB; budget is that plus about 15 percent.
Refs #217. Two internal tests called the removed SelectQuery.render method; they now go through selectView like the renderer.
Refs #217. The removed qualifier method used tableOf; the callers that replaced it now do too. The selectView comment says the view holds a copy of the clauses.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #217. Phase 3, partial; not for merge. Head 45aeef4, ci 44070740289 green (all jobs), compile-memory 44070740489 green.
Peak compiler RSS of the compile-memory fixture, MiB default / -l / -c=1 (go1.27.4):
The same code measured 5673 and 6170 MiB, so a runner varies by about 8 percent; 3b is worth about 2 to 3 percent, not the 6 percent the first run suggested. PEAK_RSS_BUDGET_KB is 7270000 (run 44066175274, 6318800 KiB, plus about 15 percent), which is no real tightening over phase 2.
3b: eight unexported methods of SelectQuery[T] became functions or share one method (selectView). Go builds a wrapper for every method of an instantiated generic type, exported or not, for the value and the pointer type. Instantiated generic text fell from 56.5 MB to 54.2 MB.
Not done: the roughly 65 unexported methods of InsertQuery[T] (the largest remaining item), UpdateQuery, DeleteQuery, ConflictQuery and Relation. The under 5 GB target is not met.