Repository navigation
fix(lint): run golangci-lint and go test once per Go module - #340
Merged
Merged
Conversation
…n cannot shift them
…t, ignore testdata and vendor go.mod
…ry lint test runs
…st absolute output and symlinked roots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The gate's Go lint and Go test runner now run once per Go module, from the module's directory, instead of one run from the repo root.
Why
A changed file in a nested module (its own go.mod, e.g. momo's bench/ with a replace to ../) made golangci-lint fail with "main module (...) does not contain package ...", so the gate reported the file NOT checked and blocked a correct commit.
go testnarrowed to a nested package failed the same way ("setup failed ... main module does not contain package").How
Testing
Unit tests in internal/lint (grouping, patterns, path mapping, stub-binary runs asserting directory, args, config and go.work behaviour) and internal/testrun (real nested module fixture). Verified on CI only; red run on a throwaway branch is recorded in a comment.