Repository navigation
test(lint): build fake module roots from t.TempDir so they are absolute on Windows - #345
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repoRelPath and goPatterns tests used
\ras a fake root. On Windows that is rooted but has no drive, so filepath.IsAbs is false and the v3.9.4 tag run failed. golangci-lint on Windows prints drive-qualified or module-relative paths, never volume-less ones, so repoRelPath is correct and only the fixtures were wrong. They now build from t.TempDir(). Verified on a workflow_dispatch run: ubuntu, macos, windows and gate green (run 42625567755).