Skip to content

test(lint): build fake module roots from t.TempDir so they are absolute on Windows - #345

Merged
piwi3910 merged 1 commit into
mainfrom
fix/windows-repo-rel-path
Nov 9, 2026
Merged

piwi3910 merged 1 commit into
mainfrom
fix/windows-repo-rel-path

Conversation

@piwi3910

@piwi3910 piwi3910 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

The repoRelPath and goPatterns tests used \r as a fake root. On Windows that is rooted but has no drive, so filepath.IsAbs is false and the v3.9.4 tag run failed. golangci-lint on Windows prints drive-qualified or module-relative paths, never volume-less ones, so repoRelPath is correct and only the fixtures were wrong. They now build from t.TempDir(). Verified on a workflow_dispatch run: ubuntu, macos, windows and gate green (run 42625567755).

@piwi3910
piwi3910 merged commit 53673cb into main Nov 9, 2026
12 checks passed
@piwi3910
piwi3910 deleted the fix/windows-repo-rel-path branch November 9, 2026 13:35
@piwi3910 piwi3910 mentioned this pull request Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant