Block state-changing debug deep links

[kobemartin]

Summary

• allow external debug-command deep links to invoke read-only research commands only
• block state-changing and unknown-risk command categories before any Bluetooth write
• hide remote URL examples for commands that cannot be invoked remotely

Why

The custom URL scheme previously allowed an external app or webpage to immediately invoke a state-changing WHOOP research command while Goose was connected.

Validation

• git diff --check
• swiftc -parse GooseSwift/*.swift GooseWorkoutLiveActivityExtension/*.swift

[tigercraft4]

Stringly-typed allowlist fails open on misclassification.

risk == "read" || risk == "keyed read" means a typo in a future command's risk field — or a new command added with a mislabeled string — silently becomes remotely invokable. There is no compiler check that the two literal strings are the only safe values.

Suggested fix: convert risk to a CommandRisk enum:

enum CommandRisk: String {
    case read = "read"
    case keyedRead = "keyed read"
    case write
    case unknown
}

var allowsRemoteInvocation: Bool {
    risk == .read || risk == .keyedRead
}

The compiler then enforces the allowlist exhaustively — a new risk variant that isn't listed here will not be remotely invokable by default.

[tigercraft4]

Confirm this is the only deep-link enforcement site.

The gate correctly consults allowsRemoteInvocation here, but verify no other code path (e.g. payload-hex form, Shortcuts integration, or a second handleDeepLink branch) bypasses this guard. A single enforcement point is the right design; the risk is that a second entry point added later will not automatically inherit it.

Consider emitting an explicit audit log when a deep link is rejected so internal tooling can detect and reclassify affected commands:

ble.record(level: .warn, source: "ble.debug_command",
    title: "deep_link.blocked",
    body: "\(command.id) risk=\(command.risk) — allowsRemoteInvocation=false")

This also helps diagnose broken Shortcuts automations without requiring a debugger.