Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection items with historical
"mintNumber":"42"metadata lost their otherwise valid collection ID because the parser decoded required and optional fields together. Parse the collection claim independently and accept canonical nonnegative display integers as numbers or legacy strings, bounded by the host integer and JavaScript safe-integer range. Invalid optional metadata stays available as raw data and does not erase the claim.Adds regressions for malformed fields and the existing Musashi transaction fixture
34adf92c…f701f9. This preserves claim parsing; it does not add collection-issuer matching or turn overlay admission into verified membership.Validation:
go test ./pkg/collection ./pkg/parse, gofmt andgit diff --checkpass. Related proposal: opldotdev/BRCs#13.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.