Skip to content

Preserve collection claims with historical numeric metadata - #28

Closed
rohenaz wants to merge 2 commits into
masterfrom
codex/collection-metadata-compat
Closed

rohenaz wants to merge 2 commits into
masterfrom
codex/collection-metadata-compat

Conversation

@rohenaz

@rohenaz rohenaz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Collection items with historical "mintNumber":"42" metadata lost their otherwise valid collection ID because the parser decoded required and optional fields together. Parse the collection claim independently and accept canonical nonnegative display integers as numbers or legacy strings, bounded by the host integer and JavaScript safe-integer range. Invalid optional metadata stays available as raw data and does not erase the claim.

Adds regressions for malformed fields and the existing Musashi transaction fixture 34adf92c…f701f9. This preserves claim parsing; it does not add collection-issuer matching or turn overlay admission into verified membership.

Validation: go test ./pkg/collection ./pkg/parse, gofmt and git diff --check pass. Related proposal: opldotdev/BRCs#13.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@rohenaz rohenaz closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant