Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review corrections verified
Fixed rollback of committed siblings sharing retained ancestry. Durable snapshot dependencies require later overlapping mutations to finish rollback before an earlier snapshot can restore; pruning preserves that order too. SQLite and real PostgreSQL storage suites pass, including shared-ancestor rollback, refused out-of-order operations, finalization and replay cleanup. The API remains dormant until runtime coordination is implemented.
Problem
Overlay rollback needs durable, transactionally correct storage primitives before any runtime coordinator can safely enable rejection or reorg recovery. The earlier combined approach mixed storage, callbacks, retry, and reorg assumptions and was stopped by review.
Change
ReversibleTopicStoragecontract without changing or activating existing engine adaptersVerification
go test ./pkg/overlay/storage -count=1go vet ./pkg/overlay/storagegit diff --checkActivation boundary
This PR has no adapter or runtime call site. OPL-4475 must add durable coordination, and OPL-4476 must add the authoritative reorg/finality source and pruning policy before any production activation. PostgreSQL contract tests compile but require Docker/CI for runtime execution.
Linear: OPL-4474
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.