Track shared-broadcaster alias wiring; no separate code change

[rohenaz]

This branch now has the same tree as #30 and is based on the current wiring branch instead of the obsolete settings branch. The original broadcaster-disabling proposal has been removed. Keep the shared Broadcaster and P2PBus so normal submission and arcade confirmation observation work.

No independent code change remains to merge here. Sigma’s corresponding documentation/test correction is https://github.com/b-open-io/sigma-auth/pull/354.

[linear]

OPL-4475

[shruggr]

Reset this branch to the rebased wiring (#30). Do not nil Broadcaster or P2PBus.

Overlay Submit is supposed to validate, broadcast (arcade), then store. Both the overlay node and the wallet can broadcast. There is no noSend/sendWith wallet in this repo or in 1sat-sdk for alias publish.

The engine order (broadcast before insert) is overlay design, not a bug. Turning broadcast off also means arcade never sees the tx, so OutputBlockHeightUpdated never restamps event scores.

Keep the shared ModuleDeps on NewModuleEngine like BAP/OPNS.

[rohenaz]

Your correction is right: my original recommendation to nil Broadcaster/P2PBus was wrong. I have preserved both dependencies, brought this branch forward with #30, and retargeted the PR onto #30 so the old settings base no longer creates a misleading diff. The trees now match; there is no independent code change left in this PR.

Sigma #354 removes the incorrect no-broadcast-on-timeout guarantee and tests that an overlay-broadcast/lost-response scenario preserves the same candidate without claiming admission or wallet finalization. No live publishing was enabled.

[shruggr]

No independent diff. Landed with #30.