Skip to content

EX-SU-Qto_ArchElementBaseQuantities - #822

Merged
SergejMuhic merged 2 commits into
bSI-InfraRoom:tunnelfrom
larswik:EX-SU-Qto_ArchElementBaseQuantities
Jul 7, 2024
Merged

EX-SU-Qto_ArchElementBaseQuantities#822
SergejMuhic merged 2 commits into
bSI-InfraRoom:tunnelfrom
larswik:EX-SU-Qto_ArchElementBaseQuantities

Conversation

@larswik

@larswik larswik commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@larswik
larswik requested a review from SergejMuhic June 4, 2024 10:58
@larswik larswik self-assigned this Jun 4, 2024
@larswik larswik added IFC Tunnel Issues or pull requests relating to IFC Tunnel project quantities Issues or pull requests relating to quantity sets BucketB Generic 4-T content labels Jun 4, 2024
@larswik

larswik commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator Author

@SergejMuhic : This is the result from discussions with domain team. Differs from your draft #711. Discuss?

@larswik larswik mentioned this pull request Jul 6, 2024
Draft
SergejMuhic
SergejMuhic requested changes Jul 6, 2024
View reviewed changes

@SergejMuhic SergejMuhic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Length and Volume seem reusable.

@larswik

larswik commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator Author

Length and Volume seem reusable.

From where?

@SergejMuhic

SergejMuhic commented Jul 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I guess we could reconcile one of the Length and Volume quantities, but I guess it is fine. We did not reconcile the quantity sets, right?

Just found out one concerning thing, the bSI documentation does not differentiate between property and quantity:
image
👀

@larswik

larswik commented Jul 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@SergejMuhic : Seems like most descriptions are specific. Can we merge?

@SergejMuhic

SergejMuhic commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator

Sure, let's merge. There was a unification on bSI with this description: "The length of the object." We just have not yet merged the reconcile PRs.

@SergejMuhic

SergejMuhic commented Jul 7, 2024

Copy link
Copy Markdown
Collaborator

Modified descriptions to fit bsi template modifying ArchElement Length and Volume descriptions

@SergejMuhic
SergejMuhic merged commit 6f04d03 into bSI-InfraRoom:tunnel Jul 7, 2024
@SergejMuhic
SergejMuhic deleted the EX-SU-Qto_ArchElementBaseQuantities branch July 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergejMuhic SergejMuhic SergejMuhic approved these changes

Assignees

@larswik larswik

Labels

BucketB Generic 4-T content IFC Tunnel Issues or pull requests relating to IFC Tunnel project quantities Issues or pull requests relating to quantity sets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larswik @SergejMuhic