TI bridge mvdxml fix - #12
Conversation
pjanck
commented
Nov 9, 2023
pjanck
commented
- Fixed some serialization mistakes
- Renamed doubled uuids
- Added some operators where deemed necessary
- Fixed an applicable entity
Fixed some serialization mistakes
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Not sure about the change here. Seems identical. Fine.
| <EntityRules> | ||
| <EntityRule EntityName="IfcCurveSegment"> | ||
| <References> | ||
| <Template> |
There was a problem hiding this comment.
Oh, my bad. I guess I shouldn't have fiddled with the file manually.
| </ConceptTemplate> | ||
| </SubTemplates> | ||
| </ConceptTemplate> | ||
| <ConceptTemplate uuid="e5d27119-bcb5-43e6-b6b3-8ababc4593f4" name="_Bridge Alignment Reference View" applicableSchema="IFC4"> |
There was a problem hiding this comment.
The guid seems fine. What is the reason for changing? If we change here, the specification would have to be changed since it is generated from there,
| </Body> | ||
| </Definition> | ||
| </Definitions> | ||
| <BaseView>2c20c595-6b25-445b-92f5-37ef9eb1825f</BaseView> |
| </Definitions> | ||
| <Template ref="8c0fd2f7-71bb-4e6e-8fdb-0c02b352f14a" /> | ||
| <TemplateRules> | ||
| <TemplateRules operator="or"> |
There was a problem hiding this comment.
Alright, this is definitely a bug. Have to fix this.
| </Concept> | ||
| </Concepts> | ||
| </ConceptRoot> | ||
| <ConceptRoot uuid="280bbb91-3d77-4b73-88d5-594762c1989d" name="IfcPositioningElement" applicableRootEntity="IfcPositioningElement"> |
There was a problem hiding this comment.
I do not understand this change. But I think it is part of Reference View, so I will remove (see below also).
| </Definitions> | ||
| <Template ref="0c93e2c2-cb23-46a8-8b9a-c772c280fc26" /> | ||
| <Requirements> | ||
| <Requirement applicability="export" requirement="notrelevant" exchangeRequirement="dcd96125-898e-4ff0-b294-eb02afe953aa" /> |
There was a problem hiding this comment.
Not sure why this was changed, but please ignore since it is Reference View. I will remove the entire Reference View.
|
I have removed the views. I am mostly fine with the changes. Just a few are not clear to me. |
|
I have fixed the serialization issue. I have accidentally used the wrong serializer. Apologies. |
2 participants
