chore(deps): bump tsx, @types/node, react, react-dom - #79
Conversation
Consolidates routine Dependabot dependency bumps that are safe together: - tsx 4.21.0 -> 4.22.4 (dev) - @types/node 22.19.21 -> 26.0.0 (dev) - react & react-dom 19.1.0 -> 19.2.7 (bumped together; react-dom@19.2.7 requires peer react@^19.2.7, so they must move in lockstep) @types/node 26 tightened the `data` listener parameter on net.Socket to `string | Buffer`; narrow it to `Buffer` at the one raw-socket read site so `chunks: Buffer[]` still type-checks (no encoding is set, so chunks are always Buffers). Supersedes #74, #76, #78. Excludes eslint-config-next 16 (#77), which requires Next 16 while this app is on Next 15. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBumps ChangesDependency Updates and Type Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Deploying agent-render with
|
| Latest commit: |
d0f6952
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c848c641.agent-render.pages.dev |
| Branch Preview URL: | https://chore-dep-bumps.agent-render.pages.dev |
|
| Filename | Overview |
|---|---|
| package.json | Version ranges updated for react/react-dom (19.1.0→19.2.7 exact pins), @types/node (^22→^26), and tsx (^4.21.0→^4.22.4) — all consistent with lockfile. |
| package-lock.json | Lockfile faithfully reflects all four package bumps; tsx now carries its own nested esbuild 0.28.1 and drops get-tsconfig, undici-types moves from 6.21.0 to 8.3.0 alongside the @types/node major. |
| tests/selfhosted/api-catalog.test.ts | Adds explicit (chunk: Buffer) annotation on the socket data listener to satisfy @types/node 26's widened string |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["@types/node 22"]
A["socket.on('data', chunk => …)\nchunk inferred as: Buffer"]
end
subgraph After["@types/node 26"]
B["socket.on('data', chunk => …)\nchunk inferred as: string | Buffer\n⚠ chunks: Buffer[] type error"]
end
subgraph Fix["PR fix"]
C["socket.on('data', (chunk: Buffer) => …)\nExplicit annotation narrows back to Buffer\n✓ chunks: Buffer[] satisfied"]
end
Before --> After
After --> Fix
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
subgraph Before["@types/node 22"]
A["socket.on('data', chunk => …)\nchunk inferred as: Buffer"]
end
subgraph After["@types/node 26"]
B["socket.on('data', chunk => …)\nchunk inferred as: string | Buffer\n⚠ chunks: Buffer[] type error"]
end
subgraph Fix["PR fix"]
C["socket.on('data', (chunk: Buffer) => …)\nExplicit annotation narrows back to Buffer\n✓ chunks: Buffer[] satisfied"]
end
Before --> After
After --> Fix
Reviews (1): Last reviewed commit: "chore(deps): bump tsx, @types/node, reac..." | Re-trigger Greptile
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewConsolidated dependency bump PR: In No security, runtime, or logic issues found.
Files Reviewed (3 files)
Reviewed by GLM-5.2 · Input: 140.6K · Output: 7K · Cached: 60.5K |
Consolidates the safe-to-merge npm Dependabot bumps into one PR (the repo's established pattern), and supersedes the individual Dependabot PRs.
Bumps
react-dom@19.2.7requires peerreact@^19.2.7, soreactandreact-domare bumped together; bumpingreact-domalone (as #78 did) failsnpm installwithERESOLVE.One code change, load-bearing for the bump
@types/node26 tightened thenet.Socketdatalistener parameter tostring | Buffer. The one raw-socket read site intests/selfhosted/api-catalog.test.tspushes intochunks: Buffer[], so the chunk is narrowed toBufferexplicitly (no encoding is set on the socket, so chunks are always Buffers).Not included
eslint-config-nextis version-locked tonext).Verification
Locally green:
lint,typecheck, 236/236 unit tests, functional e2e, build budgets. The 7 visual-regression e2e tests fail identically on cleanmain(macOS-local vs Linux-CI font anti-aliasing, ~0.01 px ratio) — a pre-existing baseline platform mismatch, not caused by this bump; CI's Linux baselines pass them.🤖 Generated with Claude Code
Summary by CodeRabbit