Skip to content

Add CI (build + test on Linux and macOS) - #4

Merged
baanish merged 1 commit into
masterfrom
add-ci-workflow
Jun 21, 2026
Merged

baanish merged 1 commit into
masterfrom
add-ci-workflow

Conversation

@baanish

@baanish baanish commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Problem

The repository has no CI. With a public release and external contributors, PRs can break cargo build or cargo test with no automated gate.

Change

Add .github/workflows/ci.yml running cargo build --locked + cargo test --locked on ubuntu-latest and macos-latest (the two supported platforms), on every push to master and every PR. Uses dtolnay/rust-toolchain@stable + Swatinem/rust-cache.

Scope is intentionally build + test only (per project preference). fmt --check and clippy -D warnings are deferred to a follow-up PR that also fixes the existing formatting/lint drift on master, so this workflow is green from day one rather than red on pre-existing issues.

This PR's own workflow run validates it (including the cross-platform cargo test on Linux) before merge.

Part of the pre-release hardening series (Wave 0 — foundation).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Set up automated continuous integration and testing pipeline across multiple platforms.

The public repository had no CI, so contributor PRs could break the build
or tests with no automated gate. Add a workflow that builds and runs the
test suite on Linux and macOS (the two supported platforms) for every push
to master and every pull request.

Scope is intentionally minimal (build + test, per project preference); fmt
and clippy gates are deferred to a follow-up that also fixes the existing
formatting/lint drift, so this workflow stays green on day one.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 2315fce2-9333-40b5-8d72-d2f005b62ed2

📥 Commits

Reviewing files that changed from the base of the PR and between 6938212 and 04aab12.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

A new GitHub Actions CI workflow is added that triggers on pushes to master and all pull requests. It runs a single test job on both ubuntu-latest and macos-latest, installs the stable Rust toolchain, enables caching, and executes cargo build --locked --verbose followed by cargo test --locked --verbose.

Changes

CI Workflow Setup

Layer / File(s) Summary
CI workflow definition
.github/workflows/ci.yml
New workflow triggered on master pushes and pull requests; runs a matrix job on Ubuntu and macOS with Rust toolchain install, caching, and cargo build/cargo test with --locked --verbose.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A pipeline springs up from the ground,
On Ubuntu and Mac, tests go round,
cargo build, then test with glee,
The CI bunny hops with --locked free,
Green checks for all, hooray! 🎉


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/ci.yml

Standard, well-structured CI config. Verified that Cargo.lock is committed and tracked (so --locked will succeed), actions are pinned to major versions, and the fail-fast: false matrix strategy is appropriate for cross-platform runs. No changes requested.


Reviewed by glm-5.2-short · Input: 21.4K · Output: 1.5K · Cached: 113.5K

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04aab1294a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml

on:
push:
branches: [master]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run push CI on the actual default branch

This repo's mainline branch is main (git branch -a shows main and no master), so restricting push events to master means the new build/test workflow will not run after PRs merge or on direct pushes to the branch that is actually used. Please target main here, or include both branch names if master is still needed somewhere.

Useful? React with 👍 / 👎.

@baanish
baanish merged commit 55fb03b into master Jun 21, 2026
4 checks passed
@baanish
baanish deleted the add-ci-workflow branch June 21, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant