Add CI (build + test on Linux and macOS) - #4
Conversation
The public repository had no CI, so contributor PRs could break the build or tests with no automated gate. Add a workflow that builds and runs the test suite on Linux and macOS (the two supported platforms) for every push to master and every pull request. Scope is intentionally minimal (build + test, per project preference); fmt and clippy gates are deferred to a follow-up that also fixes the existing formatting/lint drift, so this workflow stays green on day one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new GitHub Actions CI workflow is added that triggers on pushes to ChangesCI Workflow Setup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Standard, well-structured CI config. Verified that Reviewed by glm-5.2-short · Input: 21.4K · Output: 1.5K · Cached: 113.5K |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04aab1294a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| on: | ||
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
Run push CI on the actual default branch
This repo's mainline branch is main (git branch -a shows main and no master), so restricting push events to master means the new build/test workflow will not run after PRs merge or on direct pushes to the branch that is actually used. Please target main here, or include both branch names if master is still needed somewhere.
Useful? React with 👍 / 👎.
Problem
The repository has no CI. With a public release and external contributors, PRs can break
cargo buildorcargo testwith no automated gate.Change
Add
.github/workflows/ci.ymlrunningcargo build --locked+cargo test --lockedonubuntu-latestandmacos-latest(the two supported platforms), on every push tomasterand every PR. Usesdtolnay/rust-toolchain@stable+Swatinem/rust-cache.Scope is intentionally build + test only (per project preference).
fmt --checkandclippy -D warningsare deferred to a follow-up PR that also fixes the existing formatting/lint drift onmaster, so this workflow is green from day one rather than red on pre-existing issues.This PR's own workflow run validates it (including the cross-platform
cargo teston Linux) before merge.Part of the pre-release hardening series (Wave 0 — foundation).
🤖 Generated with Claude Code
Summary by CodeRabbit