copy-tree now checks if src, dest are sym links #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkdude
reviewed
Dec 12, 2025
src/babashka/fs.cljc
Outdated
| option. Supports same options as [[copy]]. | ||
| Returns `dest` as `Path`" | ||
| Returns `src` as `Path`" |
Contributor
There was a problem hiding this comment.
I think I'd rather just leave the return value undefined (by not mentioning it) here instead of overspecifying it.
The docstring is probably a remnant of copy's docstring.
Contributor
There was a problem hiding this comment.
Or we fix it, to align with copy and move. Either one is fine with me.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review, I think I'll omit it from the docstring for this PR to avoid scope creep.
I'll create a separate issue to review API return values.
I'll create a separate issue to review API return values.
Contributor
Author
|
@borkdude, I think, I'll start working on bb fs issues again. Are you good to merge this puppy? |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy-treenow throws ifsrcordestis a symbolic link when not following links.Closes #188
Also noticed that copy-tree returns
src, notdest, so adjusted docstring accordingly.Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.