POC Changelog viewer#21
Open
Sarabadu wants to merge 111 commits into
Open
Conversation
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Co-authored-by: Adam Foxman <adam@thefoxmans.net>
previously on a comparison page like this one [1], we were having an issue, where the changelog link was not set. this was due to the package name not being accessible for the "UsefulLinks" component. this commit fixes this issue [1]: https://react-native-community.github.io/upgrade-helper/?from=0.63.4&to=0.69.0
Bumps [terser](https://github.com/terser/terser) from 4.4.3 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Also updates the UsefulLinks class to a functional component
Fix the CompletedFilesCounter test
When running `yarn start`, the console would complain: WARNING in ./node_modules/react-diff-view/es/index.js Module Warning (from ./node_modules/source-map-loader/dist/cjs.js): Failed to parse source map from ‘~/react-native-upgrade-helper/node_modules/react-diff-view/src/utils/parse.ts' file: Error: ENOENT: no such file or directory, open ‘~/react-native-upgrade-helper/node_modules/react-diff-view/src/utils/parse.ts'
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The upgrade helper really makes the most common changes easier to be highlighted, but for the changes that are not in the create-app we have 2 cases:
In this POC we are adding a new route that gets the package name and version as part of the url and queries the changelog file for that package and version from npm (just
CHANGELOG.mdfor now, maybe requires more posible names in the future.How it looks
You can see it working here https://sarabadu.github.io/upgrade-helper/changelog/@backstage-community/plugin-announcements/0.1.2 , changing the packages and versions
Thoughts
nextversion changesTest Plan
What are the steps to reproduce?
Checklist
README.md(if needed)