Modification of ska.rust to integrate wasm32-unknown-unknown target compilation #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on targets only. Restored original versions and dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 25 25
Lines 3638 3638
=======================================
Hits 3462 3462
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
It compiles, codecov complains because of a couple of new methods I think I added for any compilation target (but are only used in wasm). If we wanted to be really pro, we should add tests also for wasm as well? |
…. TODO: add the button and un-hardcode the rc=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow to compile to wasm32-unknown-unknown. They essentially add conditional compilation attributes, as well as few new files. The core structure of the changes come from DATACIN.