🧹 [Extract shared load_module_snapshot function] by badMade · Pull Request #172 · badMade/claw-code

badMade · 2026-05-11T19:00:33Z

🎯 What:
Extracted duplicated JSON snapshot parsing logic into a shared _load_module_snapshot(path: Path) helper function in src/models.py. Both src/tools.py (load_tool_snapshot) and src/commands.py (load_command_snapshot) were updated to use this new helper.

💡 Why:
This eliminates redundant code duplication across the codebase, making it easier to maintain and read. It ensures that any future changes to how snapshots are loaded or how PortingModule instances are constructed only need to be made in one place.

✅ Verification:

Ran the full python3 -m unittest discover tests suite.
Verified all 31 tests passed successfully.
Code review confirmed the refactoring is functionally equivalent to the original implementation.

✨ Result:
Improved maintainability by reducing code duplication, leaving cleaner snapshot loading functions without changing any underlying application behavior.

PR created automatically by Jules for task 15334275623421876991 started by @badMade

Extracts the duplicated JSON parsing and PortingModule mapping logic from load_tool_snapshot (src/tools.py) and load_command_snapshot (src/commands.py) into a shared _load_module_snapshot helper in src/models.py. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

google-labs-jules · 2026-05-11T19:00:35Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

gemini-code-assist

Code Review

This pull request refactors the module snapshot loading logic by extracting it into a shared helper function, _load_module_snapshot, in src/models.py, which is now used by both src/commands.py and src/tools.py. The reviewer recommends renaming the function to remove the leading underscore to reflect its cross-module usage and suggests using json.load() with explicit UTF-8 encoding for improved efficiency and platform consistency.

gemini-code-assist · 2026-05-11T19:02:07Z

+def _load_module_snapshot(path: Path) -> tuple[PortingModule, ...]:
+    raw_entries = json.loads(path.read_text())
+    return tuple(
+        PortingModule(
+            name=entry["name"],
+            responsibility=entry["responsibility"],
+            source_hint=entry["source_hint"],
+            status="mirrored",
+        )
+        for entry in raw_entries
+    )


The helper function _load_module_snapshot is used across multiple modules (commands.py and tools.py), so the leading underscore (which typically denotes a module-private function) is inconsistent with its usage and the PR title. Additionally, using json.load() with a file object is more memory-efficient than reading the entire file into a string, and explicitly specifying encoding='utf-8' ensures consistent behavior across different platforms (e.g., Windows).

Suggested change

def _load_module_snapshot(path: Path) -> tuple[PortingModule, ...]:

raw_entries = json.loads(path.read_text())

return tuple(

PortingModule(

name=entry["name"],

responsibility=entry["responsibility"],

source_hint=entry["source_hint"],

status="mirrored",

)

for entry in raw_entries

)

def load_module_snapshot(path: Path) -> tuple[PortingModule, ...]:

with path.open(encoding="utf-8") as f:

return tuple(

PortingModule(

name=entry["name"],

responsibility=entry["responsibility"],

source_hint=entry["source_hint"],

status="mirrored",

)

for entry in json.load(f)

)

References

PEP 8: _single_leading_underscore is a weak 'internal use' indicator. Since this function is intended for use across modules in the package, the underscore should be removed. ^(link)

gemini-code-assist · 2026-05-11T19:02:07Z

 from types import MappingProxyType

-from .models import PortingBacklog, PortingModule
+from .models import PortingBacklog, PortingModule, _load_module_snapshot


Update the import to reflect the renamed load_module_snapshot function in models.py.

Suggested change

from .models import PortingBacklog, PortingModule, _load_module_snapshot

from .models import PortingBacklog, PortingModule, load_module_snapshot

gemini-code-assist · 2026-05-11T19:02:07Z

-        )
-        for entry in raw_entries
-    )
+    return _load_module_snapshot(SNAPSHOT_PATH)


Update the call site to use the renamed load_module_snapshot function.

Suggested change

return _load_module_snapshot(SNAPSHOT_PATH)

return load_module_snapshot(SNAPSHOT_PATH)

gemini-code-assist · 2026-05-11T19:02:07Z

 from types import MappingProxyType

-from .models import PortingBacklog, PortingModule
+from .models import PortingBacklog, PortingModule, _load_module_snapshot


Update the import to reflect the renamed load_module_snapshot function in models.py.

Suggested change

from .models import PortingBacklog, PortingModule, _load_module_snapshot

from .models import PortingBacklog, PortingModule, load_module_snapshot

gemini-code-assist · 2026-05-11T19:02:07Z

-        )
-        for entry in raw_entries
-    )
+    return _load_module_snapshot(SNAPSHOT_PATH)


Update the call site to use the renamed load_module_snapshot function.

Suggested change

return _load_module_snapshot(SNAPSHOT_PATH)

return load_module_snapshot(SNAPSHOT_PATH)

Copilot

Pull request overview

Refactors duplicated JSON snapshot parsing logic for tool/command “mirrored module” metadata into a shared helper in src/models.py, and updates callers to use it.

Changes:

Added a shared _load_module_snapshot(path: Path) helper in src/models.py.
Updated load_tool_snapshot() and load_command_snapshot() to delegate to the shared helper.
Consolidated snapshot parsing/PortingModule construction to reduce duplication.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/models.py	Introduces the shared snapshot-loading helper used by tool/command snapshot loaders.
src/tools.py	Replaces inline snapshot parsing with a call to the shared helper.
src/commands.py	Replaces inline snapshot parsing with a call to the shared helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

        ]
+
+
+def _load_module_snapshot(path: Path) -> tuple[PortingModule, ...]:


 from types import MappingProxyType

-from .models import PortingBacklog, PortingModule
+from .models import PortingBacklog, PortingModule, _load_module_snapshot


 from types import MappingProxyType

-from .models import PortingBacklog, PortingModule
+from .models import PortingBacklog, PortingModule, _load_module_snapshot


Extracts the duplicated JSON parsing and PortingModule mapping logic from load_tool_snapshot (src/tools.py) and load_command_snapshot (src/commands.py) into a shared _load_module_snapshot helper in src/models.py. Also fixes the auto-merge CI workflow by fully terminating the truncated js block and upgrading actions/github-script to v9 to fix the Unexpected end of input and Node.js 20 deprecation errors. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

 import json
 from collections.abc import Mapping
 from dataclasses import dataclass
 from functools import lru_cache
 from pathlib import Path
 from types import MappingProxyType

-from .models import PortingBacklog, PortingModule
+from .models import PortingBacklog, PortingModule, _load_module_snapshot


 import json
 from collections.abc import Mapping
 from dataclasses import dataclass
 from functools import lru_cache
 from pathlib import Path
 from types import MappingProxyType

-from .models import PortingBacklog, PortingModule
+from .models import PortingBacklog, PortingModule, _load_module_snapshot


      - name: Wait for checks to complete
-        uses: actions/github-script@v7
+        uses: actions/github-script@v9
        id: wait-checks


badMade · 2026-05-15T17:46:59Z

@copilot, resolve the merge conflicts in this pull request.

Extracts the duplicated JSON parsing and PortingModule mapping logic from load_tool_snapshot (src/tools.py) and load_command_snapshot (src/commands.py) into a shared _load_module_snapshot helper in src/models.py. Also fixes the auto-merge CI workflow by fully terminating the truncated js block and upgrading actions/github-script to v9 to fix the Unexpected end of input and Node.js 20 deprecation errors. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

badMade · 2026-05-25T23:07:50Z

@copilot, resolve the merge conflicts in this pull request.

Copilot · 2026-05-25T23:09:57Z

@copilot, resolve the merge conflicts in this pull request.

Resolved and merged latest main into this branch with conflicts fixed in commit 0003ba1.

Copilot AI review requested due to automatic review settings May 11, 2026 19:00

Copilot started reviewing on behalf of badMade May 11, 2026 19:01 View session

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

Copilot AI reviewed May 11, 2026

View reviewed changes

badMade marked this pull request as ready for review May 12, 2026 17:45

Copilot AI review requested due to automatic review settings May 12, 2026 17:45

Copilot started reviewing on behalf of badMade May 12, 2026 17:46 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Merge origin/main and resolve auto-merge workflow conflict

0003ba1

Copilot AI review requested due to automatic review settings May 25, 2026 23:09

badMade review requested due to automatic review settings May 25, 2026 23:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🧹 [Extract shared load_module_snapshot function]#172

🧹 [Extract shared load_module_snapshot function]#172
badMade wants to merge 4 commits into
mainfrom
extract-load-module-snapshot-15334275623421876991

badMade commented May 11, 2026

Uh oh!

google-labs-jules Bot commented May 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot May 11, 2026

Uh oh!

gemini-code-assist Bot May 11, 2026

Uh oh!

gemini-code-assist Bot May 11, 2026

Uh oh!

gemini-code-assist Bot May 11, 2026

Uh oh!

gemini-code-assist Bot May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

badMade commented May 15, 2026

Uh oh!

badMade commented May 25, 2026

Uh oh!

Copilot AI commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	from .models import PortingBacklog, PortingModule, _load_module_snapshot
	from .models import PortingBacklog, PortingModule, load_module_snapshot

	return _load_module_snapshot(SNAPSHOT_PATH)
	return load_module_snapshot(SNAPSHOT_PATH)

		]


		def _load_module_snapshot(path: Path) -> tuple[PortingModule, ...]:

Conversation

badMade commented May 11, 2026

Uh oh!

google-labs-jules Bot commented May 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

badMade commented May 15, 2026

Uh oh!

badMade commented May 25, 2026

Uh oh!

Copilot AI commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants