Skip to content

🔒 Fix command injection vulnerability in command_exists function #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
badMade wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🔒 Fix command injection vulnerability in command_exists function #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da86c51
🔒 Fix command injection vulnerability in command_exists function
badMade Apr 30, 2026
58c1d59
style: fix cargo fmt issue in rust/crates/tools/src/lib.rs
badMade Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion rust/crates/tools/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5151,7 +5151,9 @@ fn detect_powershell_shell() -> std::io::Result<&'static str> {
fn command_exists(command: &str) -> bool {
std::process::Command::new("sh")
.arg("-c")
.arg(format!("command -v {command} >/dev/null 2>&1"))
.arg("command -v \"$1\" >/dev/null 2>&1")
.arg("--")
.arg(command)
.status()
Comment on lines 5151 to 5157
.map(|status| status.success())
.unwrap_or(false)
Expand Down Expand Up @@ -8583,4 +8585,13 @@ printf 'pwsh:%s' "$1"
.into_bytes()
}
}

#[test]
fn test_command_exists() {
assert!(super::command_exists("ls") || super::command_exists("dir"));
assert!(!super::command_exists("ls; echo injected"));
assert!(!super::command_exists(
"this_command_should_not_exist_12345"
));
}
}
Loading