🎨 Palette: Hide terminal cursor during CLI spinner animation by badMade · Pull Request #8 · badMade/claw-code

badMade · 2026-04-13T03:04:24Z

🎨 Palette: Hide terminal cursor during CLI spinner animation

💡 What: Hides the terminal cursor (\x1b[?25l) while the Spinner is active and restores it (\x1b[?25h) when the spinner finishes, fails, or goes out of scope (via the Drop trait).
🎯 Why: Prevents the terminal cursor from jumping around or rendering alongside the spinner frames during long-running tasks, creating a smoother and more polished CLI experience. The Drop implementation ensures safety so the cursor is not permanently hidden if the CLI crashes or is interrupted.
📸 Before/After: Visual noise during "🦀 Thinking..." is reduced.

PR created automatically by Jules for task 8229289081376148807 started by @badMade

💡 What: Hides the terminal cursor (`\x1b[?25l`) while the `Spinner` is active and restores it (`\x1b[?25h`) when the spinner finishes, fails, or goes out of scope (via the `Drop` trait). 🎯 Why: Prevents the terminal cursor from jumping around or rendering alongside the spinner frames during long-running tasks, creating a smoother and more polished CLI experience. The `Drop` implementation ensures safety so the cursor is not permanently hidden if the CLI crashes or is interrupted. 📸 Before/After: Visual noise during "🦀 Thinking..." is reduced. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

google-labs-jules · 2026-04-13T03:04:25Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

gemini-code-assist

Code Review

This pull request implements terminal cursor management for the CLI spinner, hiding the cursor during animation and ensuring its restoration via the Drop trait. Feedback includes removing internal session artifacts, fixing an unexpanded shell command in the documentation, and refining the cursor restoration logic to be terminal-aware, which prevents side effects in non-terminal environments and unit tests.

badMade · 2026-04-22T22:40:29Z

@copilot code review

badMade · 2026-04-22T22:40:30Z

@claude code review

Copilot

Pull request overview

Improves CLI UX by hiding the terminal cursor while the Spinner is active and restoring it when the spinner completes or is dropped, reducing visual noise during long-running operations.

Changes:

Hide the cursor on first spinner tick and restore it on success/failure and via Drop.
Remove some rust/.claw/sessions/*.jsonl session artifacts.
Add new .port_sessions/*.json artifacts and a Jules note file.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
rust/crates/rusty-claude-cli/src/render.rs	Adds cursor hide/show behavior to the `Spinner`, including a `Drop` restore path.
rust/.claw/sessions/session-1775386853666-0.jsonl	Removes a local session artifact.
rust/.claw/sessions/session-1775386852257-0.jsonl	Removes a local session artifact.
rust/.claw/sessions/session-1775386842352-0.jsonl	Removes a local session artifact.
rust/.claw/sessions/session-1775386832313-0.jsonl	Removes a local session artifact.
.port_sessions/d5662f5a103444a9984129c1c8b01597.json	Adds a local session artifact (should not be committed).
.port_sessions/59b491f8b3b2439a957e0c680cd193bc.json	Adds a local session artifact (should not be committed).
.port_sessions/200c7e63f6f04a57ac6211a90e4e35d0.json	Adds a local session artifact (should not be committed).
.port_sessions/108fa52a890542199d833cd93ed0429f.json	Adds a local session artifact (should not be committed).
.Jules/palette.md	Adds a note documenting the cursor-hiding UX approach.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Agent-Logs-Url: https://github.com/badMade/claw-code/sessions/56bca0b3-24cf-4c30-a1e4-19d7b17df2c5 Co-authored-by: badMade <106821302+badMade@users.noreply.github.com>

Copilot · 2026-04-22T22:47:54Z

@copilot code review

Addressed with commit e71eaab. I fixed an error-path bug in spinner cursor restoration so cursor_hidden is only cleared after a successful Show, and added regression tests for both finish and fail write-failure paths. Screenshot: N/A (terminal-only ANSI cursor visibility behavior change).

badMade · 2026-04-23T02:42:44Z

@codex Code Review

badMade · 2026-04-23T02:43:29Z

@codex Code Review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e71eaab600

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

badMade · 2026-04-23T23:05:49Z

@codex code review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e71eaab600

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-23T23:09:06Z

+            let mut out = io::stdout();
+            let _ = execute!(out, Show);


Restore cursor using the spinner output writer

Spinner::drop always emits Show to io::stdout(), but tick hides the cursor on whichever writer the caller passed in. When a non-stdout writer is used (e.g., stderr or an in-memory writer in tests), the hide/show pair goes to different destinations, which can leave the terminal cursor hidden or inject unexpected ANSI into stdout.

Useful? React with 👍 / 👎.

@copilot, make changes based on the above suggestion.

Agent-Logs-Url: https://github.com/badMade/claw-code/sessions/e0dbbfc8-a13d-4979-912a-62bab47f0163 Co-authored-by: badMade <106821302+badMade@users.noreply.github.com>

Copilot · 2026-04-30T04:16:23Z

@codex Code Review

Completed in commit 495a33d: removed tracked .port_sessions/*.json artifacts and added .port_sessions/ to .gitignore so they won’t be reintroduced. Screenshot: N/A (no UI changes).

@codex Code Review

Completed in commit 495a33d: removed tracked .port_sessions/*.json artifacts and added .port_sessions/ to .gitignore so they won’t be reintroduced. Screenshot: N/A (no UI changes).

@codex code review

Completed in commit 495a33d: removed tracked .port_sessions/*.json artifacts and added .port_sessions/ to .gitignore so they won’t be reintroduced. Screenshot: N/A (no UI changes).

chatgpt-codex-connector · 2026-04-30T04:16:30Z

To use Codex here, create a Codex account and connect to github.

Copilot · 2026-04-30T04:20:36Z

@copilot code review

Completed review: no additional code changes were needed beyond commit 495a33d, and spinner-related tests pass (cargo test -p rusty-claude-cli spinner). Screenshot: N/A (terminal-only behavior, no UI screen change).

gemini-code-assist Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread .Jules/palette.md

Comment thread .port_sessions/108fa52a890542199d833cd93ed0429f.json Outdated

Comment thread rust/crates/rusty-claude-cli/src/render.rs

Comment thread rust/crates/rusty-claude-cli/src/render.rs

badMade requested a review from Copilot April 22, 2026 22:40

Copilot started reviewing on behalf of badMade April 22, 2026 22:40 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

fix: preserve spinner cursor recovery on write errors

e71eaab

Agent-Logs-Url: https://github.com/badMade/claw-code/sessions/56bca0b3-24cf-4c30-a1e4-19d7b17df2c5 Co-authored-by: badMade <106821302+badMade@users.noreply.github.com>

chatgpt-codex-connector Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread rust/crates/rusty-claude-cli/src/render.rs

badMade marked this pull request as ready for review April 23, 2026 14:52

Copilot AI review requested due to automatic review settings April 23, 2026 14:52

Copilot started reviewing on behalf of badMade April 23, 2026 15:02 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread rust/crates/rusty-claude-cli/src/render.rs

Comment thread .port_sessions/d5662f5a103444a9984129c1c8b01597.json Outdated

chatgpt-codex-connector Bot reviewed Apr 23, 2026

View reviewed changes

chore: remove local port session artifacts from PR

495a33d

Agent-Logs-Url: https://github.com/badMade/claw-code/sessions/e0dbbfc8-a13d-4979-912a-62bab47f0163 Co-authored-by: badMade <106821302+badMade@users.noreply.github.com>

Conversation

badMade commented Apr 13, 2026

Uh oh!

google-labs-jules Bot commented Apr 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

badMade commented Apr 22, 2026

Uh oh!

badMade commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 22, 2026

Uh oh!

badMade commented Apr 23, 2026

Uh oh!

badMade commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

badMade commented Apr 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

badMade Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 30, 2026 •

edited

Loading