Skip to content

ci: cut runner queue depth — remove issue_comment trigger and arm64 PR builds#690

Open
badMade wants to merge 3 commits into
mainfrom
claude/hopeful-newton-eG6vr
Open

ci: cut runner queue depth — remove issue_comment trigger and arm64 PR builds#690
badMade wants to merge 3 commits into
mainfrom
claude/hopeful-newton-eG6vr

Conversation

@badMade
Copy link
Copy Markdown
Owner

@badMade badMade commented Jun 2, 2026

Summary

The 20-slot runner pool was saturated (364 queued runs) causing all PR checks to stall in "queued" state indefinitely. Two workflow changes eliminate the two biggest contributors:

  • auto-merge.yml: Remove the issue_comment trigger. Each comment on any PR fired a full Auto-merge workflow run. A single busy PR with 60 comments generated 60 queued runs by itself. Review intent is already captured by the pull_request_review trigger — nothing is lost.

  • docker-publish.yml: Skip build-arm64 on pull_request events. The arm64 job never pushes anything on PRs (all push/upload steps are already gated to upstream main/release), so it only occupied a 45-minute arm runner slot without producing a useful artifact. The amd64 smoke test is sufficient for PR validation.

Expected impact

  • Eliminates the largest source of queue flooding (issue_comment → Auto-merge fan-out across all active PRs)
  • Halves the Docker runner-slot usage per PR (1 slot instead of 2 per PR event)
  • Both merge and move-latest jobs in docker-publish are unaffected — they only run on push/release events where build-arm64 still runs normally

Test plan

  • Verify Auto-merge still fires on pull_request_review events
  • Verify Auto-merge still fires on workflow_run completions
  • Verify build-amd64 + smoke test still run on PRs
  • Verify build-arm64, merge, and move-latest still run on pushes to main
  • Confirm runner queue depth stays manageable after merge

https://claude.ai/code/session_016mjwUL1zrcJrveLbFu2ngx


Generated by Claude Code

…4 PR builds

Two changes to stop flooding the 20-slot runner pool:

1. auto-merge.yml: Remove the `issue_comment` trigger. Every comment on
   every PR fired a full workflow run; a busy PR with 60 comments was
   creating 60 queued runs alone. Review intent is already captured by the
   `pull_request_review` trigger, so nothing is lost.

2. docker-publish.yml: Skip `build-arm64` on pull_request events. The arm64
   job never pushes on PR events (all push/upload steps are gated to
   upstream main/release), so it only occupies a 45-min arm runner slot
   without producing a useful artifact. The amd64 smoke test is sufficient
   for PR validation.

https://claude.ai/code/session_016mjwUL1zrcJrveLbFu2ngx
Copilot AI review requested due to automatic review settings June 2, 2026 03:07
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces GitHub Actions runner queue pressure by eliminating high-fanout workflow triggers and avoiding long-running ARM builds on pull requests, while keeping publish behavior intact for main pushes and releases.

Changes:

  • Remove the issue_comment trigger from auto-merge.yml and delete the corresponding event-handling branch in the script.
  • Skip the build-arm64 job on pull_request events in docker-publish.yml to avoid consuming ARM runner capacity for non-publishing PR runs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/docker-publish.yml Adds a job-level condition to skip ARM64 builds on PR events to reduce runner usage.
.github/workflows/auto-merge.yml Removes issue_comment as a trigger and updates workflow gating/script logic accordingly to prevent comment-driven run fan-out.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

🔎 Lint report: claude/hopeful-newton-eG6vr vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8253 on HEAD, 8253 on base (➖ 0)

🆕 New issues (3):

Rule Count
invalid-argument-type 3
First entries
run_agent.py:7317: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:13573: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:13576: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown, Unknown] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`

✅ Fixed issues (3):

Rule Count
invalid-argument-type 3
First entries
run_agent.py:13576: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown | str, Unknown | str | dict[str, str]] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`
run_agent.py:7317: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`
run_agent.py:13573: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`

Unchanged: 4354 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Auto-merge: merge failed

All checks passed and the reviewed label is present, but the automatic squash merge failed:

refusing to allow a GitHub App to create or update workflow .github/workflows/docker-publish.yml without workflows permission - https://docs.github.com/rest/pulls/pulls#merge-a-pull-request

Please merge manually or investigate the error.

View workflow run

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Auto-merge: checks failing

The following checks did not pass:

  • test (cancelled)

Please fix the failing checks before this PR can be merged.

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants