Support arbitrary sub-file paths for BundleJS badges#770
Conversation
Update the route patterns in `pages/api/bundlejs.ts` to use greedy matching (:name+) for the package name. This allows the badge service to correctly handle packages with sub-file paths, such as `@noble/hashes/sha3.js`. Added a new example to demonstrate this capability. Verified with manual testing and existing test suite. Ref: #734 Co-authored-by: amio <215282+amio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
This change enables the
bundlejsbadge service to support arbitrary sub-file paths in package names (e.g.,@noble/hashes/sha3.js).I updated the route patterns in
pages/api/bundlejs.tsto use:name+instead of:namefor both scoped and non-scoped packages. I also added a new example to the service metadata to showcase this feature.Verification:
curlto request a badge with a sub-path (/bundlejs/minzip/@noble/hashes/sha3.js).@noble/hashes/sha3.js.next-env.d.tsthat occurred during local development.PR created automatically by Jules for task 15938144163441773012 started by @amio