Startup Verification#3
Open
RealET wants to merge 9 commits into
Open
Conversation
Owner
|
I'd recommend to reset the |
This reverts commit 87476e5.
retries and delays can be adjusted instead if more than 5 seconds (50 tries) are needed.
Author
|
Ah, yeah, good idea. I implemented those changes and also got rid of |
fix: rename compatible string for Zephyr 4.1 compatibility confirmed working on cyboard hardware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than wait for a pre-set duration prior to startup, poll the sensor until we can read the proper vendor ID, then move forward. From logging with our hardware, seems to take between 1.5 and 2.5s to for the PMW3610 to initialize. Others may have different times but this approach should be more flexible and not require tuning.
This might deprecate
CONFIG_PMW3610_INIT_POWER_UP_EXTRA_DELAY_MS. What do you think @badjeff ?