fix(map): avoid mobile pin-selection flicker by replacing ?select via history API - #231
Open
badjoke-lab wants to merge 1 commit into
Open
fix(map): avoid mobile pin-selection flicker by replacing ?select via history API#231badjoke-lab wants to merge 1 commit into
badjoke-lab wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
router.replacetriggered router-driven updates; the goal is to stop the flicker while preserving deep-linking for?select=without touching Next Router behavior.Description
replaceSelectParam(placeId: string | null)which updates only theselectquery usingnew URL(window.location.href)andwindow.history.replaceStateto avoid router navigation.selectedPlaceIdviarouter.replaceby removing the effect that performed router-based updates and leave the deep-link restoration fromsearchParams.get("select")intact.replaceSelectParam(placeId)fromopenDrawerForPlaceandreplaceSelectParam(null)fromcloseDrawerso URL reflects user actions without causing re-render flicker.skipNextSelectionRef) minimally to prevent an immediate double-update after user-triggered URL writes.Testing
npm run -s lint -- components/map/MapClient.tsxwhich failed due tonext lintrequiring apages/appdirectory in this environment (lint did not validate the change here).npm run -s test:statswhich reported unrelated repository test failures (Cannot find module '@/lib/db') so full test suite could not be validated end-to-end.npx tsc --noEmitwhich produced unrelated type/fixture errors in test files, so typecheck could not be fully validated in this CI-like environment.Codex Task