Polish discover v0.1: mobile UX, per-section retry, and client caching - #290
Open
badjoke-lab wants to merge 1 commit into
Open
Polish discover v0.1: mobile UX, per-section retry, and client caching#290badjoke-lab wants to merge 1 commit into
badjoke-lab wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
components/discover/sections/shared.tsx: a short-lived in-memory cache (60s), enhancedfetchDiscoverwith cacheKey/ttl/signal/force, consistent skeleton sizing,LimitedDataNotewith optional details disclosure, and time helpers (formatTimeLabel/formatTimeTitle).activity:<tab>:<limit>), abort controller for stale requests, ARIA tab semantics and keyboard navigation, truncation/line-clamp fixes, retry button disabled state + 300ms debounce, and additive limited note rendering. (seeActivityFeedSection.tsx).stories:auto,stories:monthly), retry debounce and disabled state per tab, modal accessibility (focus trap, ESC, close aria-label), keyboard tab switching, and truncation/clamping on mobile cards. (seeStoriesSection.tsx).FeaturedCitiesSection.tsx).assets:list,assets:panel:<asset>), pill truncation and max-width control, separate retry flows for list and panel, and additive limited note. (seeAssetExplorerSection.tsx).TrendingCountriesSection.tsx,VerificationHubSection.tsx).Testing
npm run lintand verified no new lint errors introduced; warnings unchanged from baseline (passed).npm run buildand observed a successful build (pages compiled and static generation completed).npm run test:stats; most unit checks passed but the suite failed in CI environment due to an unrelated module resolution issue in generated.tmp-tests(alias import in test harness) not caused by discover changes.artifacts/discover-380.png,artifacts/discover-480.png,artifacts/discover-768.png,artifacts/discover-1280.pngto validate no horizontal page scroll and layout stability on 380/480.Codex Task