Prevent brief blank map when switching clusters/pins by deferring marker refresh - #372
Open
badjoke-lab wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
isFetchScheduledRefto track when a fetch is scheduled and use it together withisFetchingMarkersRefto avoid replacing a non-empty marker layer with an empty one prematurely inrenderClusters.isFetchScheduledRefinscheduleFetchForBoundsandclearFetchTimeout, and clearpendingFetchRefwhen the delayed fetch actually runs.updateVisibleMarkers()immediately fromhandleMapViewChangeto avoid using a stale/empty cluster result before the scheduled fetch starts.docs/map-cluster-pin-blank-investigation.mdsummarizing root cause analysis and suggested remediation options.Testing
yarn buildand the build succeeded.yarn testand all tests passed.yarn lintwith no new violations reported.Codex Task