Scanner improvements and bug fixes - #1
google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Implement OnModuleDestroy in ScannerService and close browser correctly. - Add browserPromise to handle concurrent browser initialization. - Enable shutdown hooks in main.ts. - Use separate page for Privacy Policy analysis to avoid breaking main scan. - Improve type safety by removing unnecessary 'any' casts for Prisma. - Add unit tests for ScannerService.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses several critical issues identified in the scanner module:
browserPromiseto ensure only one browser is launched and shared across requests.OnModuleDestroytoScannerServiceand enabled shutdown hooks inmain.tsto ensure the browser instance is properly closed when the application shuts down.(this.prisma as any)casts that were present due to missing Prisma client generation.ScannerServiceto verify the fix for concurrent browser initialization and lifecycle management.PR created automatically by Jules for task 4869523631262152652 started by @baeron