Skip to content

Fix path detection in preparerelease.py #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdehenne wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix path detection in preparerelease.py #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb60c75
Fix path detection in preparerelease.py
rdehenne Dec 26, 2024
96b754b
Fix typo
rdehenne Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion preparehelper/src/main/java/helper/PrepareRelease.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public static void main(String[] args) throws Exception {
public static void executePythonScript(String... args) throws Exception {
List<String> command = new ArrayList<>();
command.add("python");
// Add all provided argumentsto the command list
// Add all provided arguments to the command list
command.addAll(Arrays.asList(args));
command.add("..");

Expand Down
6 changes: 3 additions & 3 deletions scripts/preparerelease.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ def check_snow_path(path):
return snow_folder
else:
app_folder = os.path.join(path, "app")
other_folder = os.path.join(path, "other")
if os.path.exists(other_folder) and os.path.isdir(other_folder) and os.path.exists(app_folder) and os.path.isdir(app_folder):
newicons_folder = os.path.join(path, "newicons")
if os.path.exists(newicons_folder) and os.path.isdir(newicons_folder) and os.path.exists(app_folder) and os.path.isdir(app_folder):
return path
else:
print(f"The path '{path}' does not include the 'Snow' folder.")
Expand Down Expand Up @@ -366,7 +366,7 @@ def missingDrawable(appfilterpath:str,whitedir:str,otherdir:str):

if len(drawables) > 0:
print('\n\n______ Found non existent drawables ______\n')
print('Possible causes are typos or completly different naming of the icon\n\n')
print('Possible causes are typos or completely different naming of the icon\n\n')
for item in drawables:
toprint = etree.tostring(item,encoding='unicode',method='xml')
print(f'{toprint}')
Expand Down