feat: Phase 2 — recommender engine with 15+ test scenarios - #4
Merged
Merged
Conversation
Pure function recommend(DataAvailability) → Recommendation[] that maps user data flags to a ranked list of SAE methods with rationale and caveats. Implements §3 priority table from docs/SAE-CATALOGUE.md: - Filters methods by required inputs and target type - Scores methods by scenario (poverty, binary/proportion, count, continuous) - Handles outlier, spatial, out-of-sample, and weights sub-scenarios - Always appends direct estimator last as a benchmark - Sets stataV14Warning for methods with stataMinVersion > 14 - Builds whyApplicable strings and inferred caveats per scenario 380 tests pass (56 new recommender tests + 324 existing). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure function recommend(DataAvailability) → Recommendation[] that maps user data flags to a ranked list of SAE methods with rationale and caveats.
Implements §3 priority table from docs/SAE-CATALOGUE.md:
380 tests pass (56 new recommender tests + 324 existing).