Skip to content

make SCI registers readable and make plugins installable#119

Merged
baldram merged 7 commits intobaldram:masterfrom
CelliesProjects:make-SCI-registers-readable
Apr 8, 2026
Merged

make SCI registers readable and make plugins installable#119
baldram merged 7 commits intobaldram:masterfrom
CelliesProjects:make-SCI-registers-readable

Conversation

@CelliesProjects
Copy link
Copy Markdown

@CelliesProjects CelliesProjects commented Mar 14, 2026

I opened this PR to be able to read the SCI status registers.

@CelliesProjects CelliesProjects marked this pull request as draft March 14, 2026 15:20
@CelliesProjects CelliesProjects marked this pull request as ready for review March 16, 2026 12:50
@CelliesProjects
Copy link
Copy Markdown
Author

CelliesProjects commented Mar 16, 2026

I expanded the scope of this PR to make all *.plg files installable.

@CelliesProjects CelliesProjects marked this pull request as draft March 22, 2026 08:59
@CelliesProjects CelliesProjects changed the title make SCI registers readable make SCI registers readable and make plugins installable Mar 22, 2026
@CelliesProjects
Copy link
Copy Markdown
Author

@baldram
I started this as a poc/test to let the decoder decide what codec is running. That works fine now.
That part needs readRegister() public.

The later changes are required so that 16 bit flac files can be decoded and recognised by my stream library.

@CelliesProjects CelliesProjects marked this pull request as ready for review March 25, 2026 21:21
@CelliesProjects
Copy link
Copy Markdown
Author

@baldram Could you please review these changes?

@baldram
Copy link
Copy Markdown
Owner

baldram commented Apr 8, 2026

@CelliesProjects Thank you for letting me know that this change is complete and the POC/test phase has been wrapped up. Will 👀

@baldram
Copy link
Copy Markdown
Owner

baldram commented Apr 8, 2026

Thank you @CelliesProjects! Looks good. We will need to add a proper description to the commit.

Theoretically there is a low-impact breaking change: PLUGIN_SIZE macro renamed to
per-patch constants. Users should replace with PATCHES_FLAC_SIZE, PATCHES_FLAC_LATM_SIZE,
PATCHES_LATM_SIZE, or PATCHES_PITCH_SIZE as appropriate.

@baldram baldram merged commit 25b4725 into baldram:master Apr 8, 2026
@baldram
Copy link
Copy Markdown
Owner

baldram commented Apr 8, 2026

@CelliesProjects Are you able to use it directly from master without me releasing a new version?

@CelliesProjects CelliesProjects deleted the make-SCI-registers-readable branch April 9, 2026 07:41
@CelliesProjects
Copy link
Copy Markdown
Author

@baldram Thanks for the quick merge!

I think a new release might be in place. Very convenient for novice users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants