Implement a text mode for non-wordlist text files#7
Open
gwn wants to merge 1 commit intobalzss:masterfrom
Open
Implement a text mode for non-wordlist text files#7gwn wants to merge 1 commit intobalzss:masterfrom
gwn wants to merge 1 commit intobalzss:masterfrom
Conversation
Users can now supply any kind of plain text file to type its contents exactly; as opposed to the shuffled word approach of the wordlist mode. One gotcha is that since the typing stage is of width 80, the user-supplied text file should be word wrapped to 80 columns or it will break the layout.
Owner
|
Hi, thanks for the contribution! I will try to find some time to go over your code as soon as I can. I like the idea of a plain text mode. Regarding the wrapping problem: I like the "configurable width" solution because it would be useful even for normal use. Or that could be combined with the automatic formatting so if the user defines a width then it formats the text to fit that width. What do you think about this? |
Collaborator
|
I think it'd be great if the plain text mode could support shuffling paragraphs. For example: Users can now supply any kind of plain text file to type its
contents exactly; as opposed to the shuffled word approach of the
wordlist mode.
One gotcha is that since the typing stage is of width 80, the
user-supplied text file should be word wrapped to 80 columns or it
will break the layout.
We can either add a warning to the docs regarding this issue; or
make the width configurable; or word-wrap the user-supplied text
file automatically to 80 columns.Would randomly select one of the three paragraphs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this is a nice little typing tutor, thanks for this :)
Don't know if you'd be interested but I will be making a couple of
pull requests for the changes I made in my own fork. Cheers.
Users can now supply any kind of plain text file to type its
contents exactly; as opposed to the shuffled word approach of the
wordlist mode.
One gotcha is that since the typing stage is of width 80, the
user-supplied text file should be word wrapped to 80 columns or it
will break the layout.
We can either add a warning to the docs regarding this issue; or
make the width configurable; or word-wrap the user-supplied text
file automatically to 80 columns.