Merged
Conversation
c5d530e to
b0d61f9
Compare
giboin
reviewed
Aug 20, 2025
3fd42a3 to
2ac8eab
Compare
giboin
reviewed
Aug 21, 2025
b7c5c01 to
a99dcf7
Compare
giboin
reviewed
Aug 21, 2025
lib/src/adaptive/widgets/layers/gesture_indicator_system_nav_bar_layer.dart
Outdated
Show resolved
Hide resolved
giboin
approved these changes
Aug 21, 2025
Member
Author
|
Score pana : 160/160 |
Member
|
@alexisdelage if you add the tree buttons. You should add the all the options available on pixel 9: |
T-moz
reviewed
Aug 26, 2025
T-moz
reviewed
Aug 26, 2025
Member
Author
@T-moz Do you have an example of what 2-buttons look like? I never saw this option before. Also not sure if it is useful, since the main goal here is to anticipate bigger bottom safe-area (I doubt 2-button navigation bar would be bigger in height than 3-button) |
07b678f to
d513d9c
Compare
…ster because it is extensions on WidgetTester
BREAKING: WindowConfigData.homeIndicator renamed to systemNavBar
All goldens are updated because of the inner padding in TextField that has been updated
607a7f3 to
d70a3c8
Compare
d70a3c8 to
7013a90
Compare
T-moz
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Add a feature to test with a 3-button system navigation bar.
Re-use the Pixel5 config, but with the optional parameter for displaying the 3-button navbar instead of the default gestures-navigation.
Why
Being able to test an app with a large bottom safe-area, especially given the fact that
Scaffolddoes not always add the bottom safe area on our screens.