Skip to content

Function isOrderEncodable should also verify that the order's B value is not zero #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barakman wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −2
Open

Function isOrderEncodable should also verify that the order's B value is not zero #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86a8dc2
Function `isOrderEncodable` should also verify that the order's B val…
barakman Dec 16, 2025
6b97cc6
Fix lint error
barakman Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/utils/encoders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ export const encodeOrders = ([order0, order1]: [DecodedOrder, DecodedOrder]): [

export const isOrderEncodable = (order: DecodedOrder): boolean => {
try {
encodeOrder(order);
return true;
return encodeOrder(order).B > 0n;
Copy link
Copy Markdown
Contributor

@zavelevsky zavelevsky Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is more correct to enforce this inside encodeOrder - and not in isOrderEncodable which is a function that seems to only be used in the tests

Copy link
Copy Markdown
Collaborator Author

@barakman barakman Apr 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the SDK of the new carbon version, I have ended up implementing it in a separate function named validOrder.

Other than getting rid of the "toxic" usage of try/catch (can fail for any other unrelated bug or error), it also seems the more correct way to handle order-creation.

In this version of carbon, the conditions are much more simple, and if you decide to adopt the suggestion above, then you'll just need to put your current checks in that function, and then add this check (B > 0) on top.

} catch {
return false;
}
Expand Down