Conversation
…s, Continue button, carried badge, exportLabels removal, page subtitle, plan docs Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
…n, remove HStack wrapper Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
🤖 Version Bump AdvisoryWarnings
Version Updates✅ Radar: 0.5.0-pre12 → 0.5.0-pre13 📖 See CHANGELOG.md for detailed guidelines. This is an automated advisory. Review the detected changes and update versions accordingly. |
There was a problem hiding this comment.
Pull request overview
This PR completes the final 11 polish items for HINT (Human-Involved Numerical Tuning) sweep mode, bringing the feature to 57/57 items complete. The changes add TypeScript type definitions for HINT state management, implement an inline "Continue to Sweep" button in the Svelte frontend for the awaiting_labels state, polish the macOS visualiser with a carried-over label badge and removal of the obsolete export labels functionality, and update the page subtitle to match the sweep dashboard description.
Changes:
- Added TypeScript interfaces (
HINTState,HINTRound,LabelProgress) matching Go backend structs for HINT sweep state management - Implemented inline "Continue to Sweep" button in Svelte sweeps page for
awaiting_labelsstate with proper error handling and state refresh - Added "↻ carried" badge in macOS visualiser label panel for tracks with
labelerId == "hint-carryover" - Removed obsolete
exportLabels()method and corresponding test from macOS visualiser - Updated page subtitle to British English phrasing matching sweep dashboard
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
web/src/lib/types/lidar.ts |
Added TypeScript interfaces for HINT state, rounds, and label progress matching Go backend structs |
web/src/routes/lidar/sweeps/+page.svelte |
Implemented handleContinueHINT() function, inline continue button for awaiting_labels state, and updated page subtitle to British English |
tools/visualiser-macos/VelocityVisualiser/UI/ContentView.swift |
Added carried-over label badge display when track.labelerId == "hint-carryover" |
tools/visualiser-macos/VelocityVisualiser/App/AppState.swift |
Removed obsolete exportLabels() method |
tools/visualiser-macos/VelocityVisualiserTests/CoverageBoostTests.swift |
Removed test for deleted exportLabels() functionality |
docs/plans/lidar-sweep-hint-mode-plan.md |
Marked all 11 remaining items complete, updated status to 57/57 ✅ |
docs/lidar/operations/hint-sweep-mode.md |
Marked P1.4, P2.2, Phase 5, and Phase 6 items complete, updated summary |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…actor RunBrowserViewTests for improved readability
…setup in ContentViewTests and RunBrowserViewTests
…labels cache tests
… new VRLOG replay
…anagement - Introduced `PlaybackControlsDerivedState` to encapsulate UI state logic for playback controls in `ContentView.swift`. - Updated `PlaybackRPCClient` protocol and `VisualiserClient` class to return `VisualiserPlaybackStatus` from playback control methods. - Enhanced `AppState` tests to include scenarios for playback control interactions using a mock `FakePlaybackRPCClient`. - Added unit tests for `PlaybackControlsDerivedState` to verify UI behavior based on playback mode and connection state. - Improved coverage in existing tests by integrating playback command client mock and ensuring proper state transitions during playback operations.
… tracks - Added ClassifyFeatures method to classify objects from pre-built feature values. - Updated TrackClassifier to use ClassifyFeatures for VRLOG replay. - Introduced classifyOrConvert function to handle empty ObjectClass during replay. - Enhanced tests to verify classification consistency and reclassification behavior. - Updated visualiser.proto to reflect new ObjectClass definitions and user-assignable labels.
… peak speed with a dashed line indicator
…nt and priority details
…tClass enum, track field parity, checklist Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
…ved data handling and UI clarity
…nd improve TrackHistoryGraphView data handling
… to use persistent peak speed
…information in AboutView
This pull request standardizes the naming of the Markdown formatting target across the codebase from
format-markdowntoformat-docs, updates documentation to reflect this change, and advances the project version. Additionally, it updates backlog tracking and marks the completion of all HINT sweep mode polish items.Formatting target standardization:
format-markdowntoformat-docsin theMakefile,.pre-commit-config.yaml, and associated documentation, ensuring consistency across configuration, help text, and README references. [1] [2] [3] [4] [5] [6]Version and backlog updates:
0.5.0-pre12to0.5.0-pre13in theMakefile.Documentation improvements: