Skip to content

Comments

[mac][js] ui polish#328

Merged
ddol merged 44 commits intomainfrom
copilot/complete-backlog-items-polishing
Feb 25, 2026
Merged

[mac][js] ui polish#328
ddol merged 44 commits intomainfrom
copilot/complete-backlog-items-polishing

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

This pull request standardizes the naming of the Markdown formatting target across the codebase from format-markdown to format-docs, updates documentation to reflect this change, and advances the project version. Additionally, it updates backlog tracking and marks the completion of all HINT sweep mode polish items.

Formatting target standardization:

  • Renamed the Markdown formatting target from format-markdown to format-docs in the Makefile, .pre-commit-config.yaml, and associated documentation, ensuring consistency across configuration, help text, and README references. [1] [2] [3] [4] [5] [6]

Version and backlog updates:

  • Updated the project version from 0.5.0-pre12 to 0.5.0-pre13 in the Makefile.
  • Moved two platform hardening items from the v0.5 backlog to the v0.5.1 backlog and added new tracking items for SWEEP/HINT platform hardening, HINT sweep polish, and ObjectClass schema alignment. [1] [2]

Documentation improvements:

  • Marked the HINT sweep mode as fully complete, updating its status and summary to reflect that all polish items are finished.
  • Checked off all previously incomplete polish tasks in the HINT sweep mode documentation, including label panel improvements, removal of the export labels button, inline continue button, new TypeScript types, and shared page subtitle. [1] [2]

Copilot AI and others added 2 commits February 24, 2026 03:22
…s, Continue button, carried badge, exportLabels removal, page subtitle, plan docs

Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
…n, remove HStack wrapper

Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
Copilot AI changed the title [WIP] Complete tasks from BACKLOG.md for polish and hardening Complete HINT sweep polish items (Phase 5–6, macOS visualiser P1/P2) Feb 24, 2026
@ddol ddol marked this pull request as ready for review February 24, 2026 03:28
Copilot AI review requested due to automatic review settings February 24, 2026 03:28
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

🤖 Version Bump Advisory

Warnings

⚠️ Database migration detected

  • Files: internal/db/migrations/000012_add_track_quality_metrics.up.sql,internal/db/migrations/000013_create_site_config_periods.up.sql,internal/db/migrations/000015_add_site_map_fields.up.sql,internal/db/migrations/000016_lidar_labels.up.sql,internal/db/migrations/000018_add_quality_label.up.sql,internal/db/migrations/000019_add_lidar_labels_scene_source.up.sql,internal/db/migrations/000020_create_lidar_scenes.up.sql,internal/db/migrations/000022_create_lidar_sweeps.up.sql,internal/db/migrations/000023_add_vrlog_path.up.sql,internal/db/migrations/000024_add_sweep_metadata.up.sql,internal/db/migrations/000025_add_label_source.up.sql,internal/db/migrations/000028_create_lidar_evaluations.up.sql,internal/db/migrations/000029_expand_label_vocabulary.up.sql
  • Review for breaking changes (MAJOR) vs additive changes (MINOR)

Version Updates

✅ Radar: 0.5.0-pre12 → 0.5.0-pre13
✅ PDF Generator: 0.5.0-pre12 → 0.5.0-pre13
✅ Web Frontend: 0.5.0-pre12 → 0.5.0-pre13


📖 See CHANGELOG.md for detailed guidelines.

This is an automated advisory. Review the detected changes and update versions accordingly.

@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the final 11 polish items for HINT (Human-Involved Numerical Tuning) sweep mode, bringing the feature to 57/57 items complete. The changes add TypeScript type definitions for HINT state management, implement an inline "Continue to Sweep" button in the Svelte frontend for the awaiting_labels state, polish the macOS visualiser with a carried-over label badge and removal of the obsolete export labels functionality, and update the page subtitle to match the sweep dashboard description.

Changes:

  • Added TypeScript interfaces (HINTState, HINTRound, LabelProgress) matching Go backend structs for HINT sweep state management
  • Implemented inline "Continue to Sweep" button in Svelte sweeps page for awaiting_labels state with proper error handling and state refresh
  • Added "↻ carried" badge in macOS visualiser label panel for tracks with labelerId == "hint-carryover"
  • Removed obsolete exportLabels() method and corresponding test from macOS visualiser
  • Updated page subtitle to British English phrasing matching sweep dashboard

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web/src/lib/types/lidar.ts Added TypeScript interfaces for HINT state, rounds, and label progress matching Go backend structs
web/src/routes/lidar/sweeps/+page.svelte Implemented handleContinueHINT() function, inline continue button for awaiting_labels state, and updated page subtitle to British English
tools/visualiser-macos/VelocityVisualiser/UI/ContentView.swift Added carried-over label badge display when track.labelerId == "hint-carryover"
tools/visualiser-macos/VelocityVisualiser/App/AppState.swift Removed obsolete exportLabels() method
tools/visualiser-macos/VelocityVisualiserTests/CoverageBoostTests.swift Removed test for deleted exportLabels() functionality
docs/plans/lidar-sweep-hint-mode-plan.md Marked all 11 remaining items complete, updated status to 57/57 ✅
docs/lidar/operations/hint-sweep-mode.md Marked P1.4, P2.2, Phase 5, and Phase 6 items complete, updated summary

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 95.21912% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/lidar/l6objects/classification.go 87.09% 6 Missing and 6 partials ⚠️

📢 Thoughts on this report? Let us know!

@ddol ddol changed the title Complete HINT sweep polish items (Phase 5–6, macOS visualiser P1/P2) [mac][js] ui polish Feb 25, 2026
ddol added 12 commits February 24, 2026 16:08
…actor RunBrowserViewTests for improved readability
…setup in ContentViewTests and RunBrowserViewTests
…anagement

- Introduced `PlaybackControlsDerivedState` to encapsulate UI state logic for playback controls in `ContentView.swift`.
- Updated `PlaybackRPCClient` protocol and `VisualiserClient` class to return `VisualiserPlaybackStatus` from playback control methods.
- Enhanced `AppState` tests to include scenarios for playback control interactions using a mock `FakePlaybackRPCClient`.
- Added unit tests for `PlaybackControlsDerivedState` to verify UI behavior based on playback mode and connection state.
- Improved coverage in existing tests by integrating playback command client mock and ensuring proper state transitions during playback operations.
ddol added 12 commits February 24, 2026 16:08
… tracks

- Added ClassifyFeatures method to classify objects from pre-built feature values.
- Updated TrackClassifier to use ClassifyFeatures for VRLOG replay.
- Introduced classifyOrConvert function to handle empty ObjectClass during replay.
- Enhanced tests to verify classification consistency and reclassification behavior.
- Updated visualiser.proto to reflect new ObjectClass definitions and user-assignable labels.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 68 out of 75 changed files in this pull request and generated no new comments.

Copilot AI and others added 2 commits February 25, 2026 00:55
…tClass enum, track field parity, checklist

Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
Co-authored-by: ddol <445312+ddol@users.noreply.github.com>
Copilot AI changed the title [mac][js] ui polish Update proto contract plan with implemented reality (ObjectClass enum, track field parity) Feb 25, 2026
@ddol ddol merged commit fe1b34a into main Feb 25, 2026
23 checks passed
@ddol ddol deleted the copilot/complete-backlog-items-polishing branch February 25, 2026 05:04
@ddol ddol changed the title Update proto contract plan with implemented reality (ObjectClass enum, track field parity) [mac][js] ui polish Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants