Skip to content

feat(doc): include bao test framework introduction#71

Open
Diogo21Costa wants to merge 2 commits into
wip/testingfrom
feat/testing-introduction
Open

feat(doc): include bao test framework introduction#71
Diogo21Costa wants to merge 2 commits into
wip/testingfrom
feat/testing-introduction

Conversation

@Diogo21Costa

Copy link
Copy Markdown
Member

PR Description

In this pull request, I'm adding content to the "Overview" section of the Bao test framework documentation.

This update focuses solely on the "Overview" section, providing an overview of the core components of the Bao test framework.

Do you have any suggestions or feedback concerning the content provided in the overview section?

danielRep
danielRep previously approved these changes Oct 23, 2023

@danielRep danielRep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add @Diogo21Costa , seems good to me as a small introduction to the document, since the next section I assume you will explain the "architecture" of the framework.

@josecm

josecm commented Oct 26, 2023

Copy link
Copy Markdown
Member

Does this PR supersedes #65 ?

Comment thread source/development/testing.rst Outdated
Comment thread source/development/testing.rst Outdated
Comment thread source/development/testing.rst Outdated
@Diogo21Costa

Copy link
Copy Markdown
Member Author

Does this PR supersedes #65 ?

Yes, it does @josecm.

Comment thread source/development/testing.rst Outdated
Comment thread source/development/testing.rst Outdated
danielRep
danielRep previously approved these changes Nov 20, 2023

@josecm josecm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be completely honest, the C library and Nix build system descriptions are a bit confusing. From these descriptions I would not get what they are meant to do.

@Diogo21Costa

Copy link
Copy Markdown
Member Author

To be completely honest, the C library and Nix build system descriptions are a bit confusing. From these descriptions I would not get what they are meant to do.

@josecm I agree. The commit 8543e50 includes some improvements. What do you think of this version?

@danielRep danielRep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase it with main and solve the checker issues.

Comment thread source/development/testing.rst Outdated
Comment thread source/development/testing.rst Outdated
Comment thread source/development/testing.rst Outdated
@Diogo21Costa Diogo21Costa force-pushed the feat/testing-introduction branch from f2160d8 to 198690e Compare December 18, 2023 14:12
Signed-off-by: Diogo21Costa <diogoandreveigacosta@gmail.com>
@Diogo21Costa Diogo21Costa force-pushed the feat/testing-introduction branch from 198690e to 020fe09 Compare December 18, 2023 14:18
danielRep
danielRep previously approved these changes Dec 18, 2023
@josecm

josecm commented Feb 1, 2024

Copy link
Copy Markdown
Member

To be completely honest, the C library and Nix build system descriptions are a bit confusing. From these descriptions I would not get what they are meant to do.

@josecm I agree. The commit 8543e50 includes some improvements. What do you think of this version?

@Diogo21Costa TBH, I still think these descriptions are confusing, especially the C library one. Using simpler language, with fewer adjectives and more straight-to-the-point ideas, would be best.

Comment thread source/development/testing.rst Outdated
Comment on lines +8 to +10
1. **C Library** - This library that streamlines testing by providing macros, pre-processed logging
prompts, and an entry-point-based system, aiming to facilitating the integration of developer
tests in the software stack, such as the hypervisor or guest components.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. **C Library** - This library that streamlines testing by providing macros, pre-processed logging
prompts, and an entry-point-based system, aiming to facilitating the integration of developer
tests in the software stack, such as the hypervisor or guest components.
1. **C Library** - This library provides a framework for writing tests. It defines (i) a runtime that automates the invocation of function unit tests and (ii) an API that mainly provides a way of outputing test results in a standard format that can be parsed by the Python Tool (see below).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

Comment on lines +12 to +16
2. **Nix Build System** - The Nix Build System introduces an abstraction layer for system builds,
facilitating a modular construction of the software stack for comprehensive testing. It
encompasses a series of nix recipes that allow the compilation and build of three distinct
layers: (i) the hypervisor, (ii) multiple guests (e.g., baremetal, freeRTOS, etc.), and (iii)
the firmware.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. **Nix Build System** - The Nix Build System introduces an abstraction layer for system builds,
facilitating a modular construction of the software stack for comprehensive testing. It
encompasses a series of nix recipes that allow the compilation and build of three distinct
layers: (i) the hypervisor, (ii) multiple guests (e.g., baremetal, freeRTOS, etc.), and (iii)
the firmware.
2. **Nix Build System** - The Nix Build System introduces an abstraction layer for system builds,
facilitating a modular construction of the target software stack used for testing. It
encompasses a series of nix recipes that allow the compilation and build of three distinct
layers: (i) the hypervisor, (ii) multiple guests (e.g., baremetal, freeRTOS, etc.), and (iii)
the firmware.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

Signed-off-by: Diogo Costa <diogoandreveigacosta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants