Repository navigation
fix(verify): restore reliable local checks - #102
Merged
Merged
Conversation
- SQLite 3.54 can exit after pre-commands with -bail, hiding note updates and SQL errors - Let sqlite3 report query failures and cover invalid schemas with a regression test - Give end-to-end verify tests temporary daemon logs instead of scanning the host log Impact: note changes stay detectable and verification completes regardless of host log size
Reviewer's GuideThe PR restores reliable SQLite-based semantic change detection by allowing the query to execute under read-only mode, adds invalid-schema regression coverage, and makes affected verification tests deterministic by using temporary daemon logs. Sequence diagram for SQLite note-change token verificationsequenceDiagram
participant Verify as Verification
participant Token as SQLiteNoteChangeToken
participant SQLite as sqlite3
participant DB as SQLiteDatabase
Verify->>Token: SQLiteNoteChangeToken(dbPath)
Token->>SQLite: execute -batch -readonly query
SQLite->>DB: read Bear schema and note data
alt valid Bear database
DB-->>SQLite: semantic note result
SQLite-->>Token: query output
Token-->>Verify: change token
else missing Bear tables
SQLite-->>Token: SQL error
Token-->>Verify: nonzero error
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
barad1tos
marked this pull request as ready for review
September 28, 2026 18:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
── Summary ─────────────────────────────────
SQLite 3.54 can exit after the setup commands when
-bailis present, leaving the note change query unexecuted. Two end-to-end verification tests also read the operator's daemon log, which makes the suite depend on host log size. This restores semantic change detection and makes local verification repeatable.── Changes ─────────────────────────────────
── Validation ──────────────────────────────
go test -p=1 -count=1 -race -coverpkg=./... -coverprofile=/private/tmp/noxctl-compatibility-coverage.out -covermode=atomic ./...— passed; total statement coverage 83.9%.go build ./...andgo vet ./...— passed.golangci-lint v2.12.2 run ./...— 0 issues.── Notes ───────────────────────────────────
No live Bear apply was run. The Go 1.27 toolchain update is a separate follow-up.
Summary by Sourcery
Restore reliable local verification by fixing SQLite change detection and isolating verification tests from host daemon logs.
Bug Fixes:
Enhancements:
Tests: