Repository navigation
chore(go): require Go 1.27 - #103
Merged
Merged
Conversation
Reviewer's GuideThe PR makes Go 1.27 the consistent minimum across module metadata, CI, CodeQL, linting, tests, and user documentation, while applying behavior-preserving Go idiom and composite-literal updates; validation reports clean builds, vet/lint/tidy checks, and race-enabled tests. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="go.mod" line_range="3" />
<code_context>
module github.com/barad1tos/noxctl
-go 1.26.2
+go 1.27
require (
</code_context>
<issue_to_address>
**nitpick:** The repository now requires Go 1.27, but CONTRIBUTING.md still instructs contributors to install Go 1.26 or newer, and tests/bear/config/dispatch_test.go still describes Go 1.26 in its comment. These references contradict the module's minimum and can lead contributors to use an unsupported toolchain.
**Suggested fix:** Update the remaining Go 1.26 references in CONTRIBUTING.md and tests/bear/config/dispatch_test.go to Go 1.27.
</issue_to_address>
### Comment 2
<location path="README.md" line_range="1" />
<code_context>
-<p align="center">
- <img src="docs/screenshots/repo_facade.svg" alt="noxctl — declarative Bear notes for the terminal" width="100%" />
-</p>
+<img src="docs/screenshots/repo_facade.svg" alt="noxctl — declarative Bear notes for the terminal" width="100%" />
</code_context>
<issue_to_address>
**nitpick:** The README image is no longer wrapped in the previous centered `<p align="center">` element, so it renders with the Markdown document's default alignment instead of centered like the prior README.
**Suggested fix:** Retain the centering wrapper or replace it with an equivalent Markdown-supported alignment mechanism.
```suggestion
<p align="center">
<img src="docs/screenshots/repo_facade.svg" alt="noxctl — declarative Bear notes for the terminal" width="100%" />
</p>
```
</issue_to_address>Sourcery assessment
Approved.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a65f14f54f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Keep the module minimum, CI toolchains, and lint version aligned so dependency updates are checked with the compiler version this repository supports. 1. Toolchain: require Go 1.27, use Go 1.27.1 in CI and CodeQL, and pin golangci-lint 2.14.0. 2. Compatibility: apply the Go 1.27 struct literal and string idioms reported by the updated linter without changing runtime behavior. 3. Docs and checks: update the installation requirement, test comment, checksums, and README formatting. Impact: local builds and CI consistently require Go 1.27 or newer.
barad1tos
force-pushed
the
chore/go-1-27
branch
from
September 28, 2026 19:37
a65f14f to
3e199b2
Compare
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
── Summary ─────────────────────────────────
Require Go 1.27 consistently across the module, CI, CodeQL, and installation instructions. The existing module still declared Go 1.26.2 while the local upgrade used 1.27, which left CI and its linter on the older toolchain.
── Changes ─────────────────────────────────
── Validation ──────────────────────────────
go build ./...— passed.go vet ./...— passed.golangci-lint run ./...(v2.14.0) — 0 issues.go mod tidy -diff— no changes.go test -p=1 -count=1 -race -coverpkg=./... -covermode=atomic ./...— passed, 83.9% statement coverage.── Notes ───────────────────────────────────
Go 1.27 is now the minimum supported version. The CI toolchain is pinned to the current 1.27.1 patch release.
Summary by Sourcery
Align the project’s module, tooling, CI, code, and documentation with Go 1.27.
Enhancements:
Build:
CI:
Documentation: