Skip to content

Preserve empty adapter metadata fields - #7

Merged
barlevalon merged 1 commit into
mainfrom
review-adapter-title-only
Aug 22, 2026
Merged

Preserve empty adapter metadata fields#7
barlevalon merged 1 commit into
mainfrom
review-adapter-title-only

Conversation

@barlevalon

Copy link
Copy Markdown
Owner

Summary

  • preserve empty artist and title fields in the canonical status<TAB>artist<TAB>title adapter record
  • render title-only metadata as the title without an artist separator
  • simplify the runtime path to parse adapter output once and format the parsed fields directly
  • reject malformed and legacy plain-text adapter output while clearing parsed values

Tests

  • bash -n nowplaying.tmux scripts/*.sh
  • ./scripts/test.sh
  • shellcheck nowplaying.tmux scripts/*.sh

The suite covers complete, title-only, artist-only, and empty metadata records; malformed records; Linux adapter field preservation; and end-to-end title-only rendering.

Residual risks

  • The tab-delimited protocol cannot represent literal tabs, newlines, or carriage returns in metadata; such records are rejected.
  • The unchanged macOS MediaRemote adapter was not exercised against a live media source in this environment.

@barlevalon
barlevalon force-pushed the review-adapter-title-only branch from 98e7c7c to 64631bc Compare August 22, 2026 15:47
@barlevalon
barlevalon merged commit 60d7cc3 into main Aug 22, 2026
2 checks passed
@barlevalon
barlevalon deleted the review-adapter-title-only branch August 22, 2026 15:47
@barlevalon
barlevalon restored the review-adapter-title-only branch August 22, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant