Fix several memory issues#4
Merged
barsnick merged 4 commits intovalkyrie-qt5-qt6from Apr 15, 2026
Merged
Conversation
vkPoptGetNextOpt() now accepts a buffer length and writes option arguments with snprintf() so long option values cannot overflow the caller's arg_val buffer. Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
barsnick
force-pushed
the
fix/memory-scope-review
branch
from
d83b630 to
8f09894
Compare
Hold the toLatin1() result in a QByteArray so the popen() command pointer remains valid for the duration of the call, avoiding a dangling pointer to a temporary. Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Also avoid useless assignment after freeing. Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
barsnick
force-pushed
the
fix/memory-scope-review
branch
from
8f09894 to
be21326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.