chore: strip issue slugs from NEWS.md and ignore revdep/ (PUNY-fuqwajas) - #95
Merged
Merged
Conversation
The changelog carried 14 Fiberplane issue slugs (PUNY-xxxxxxxx) that mean nothing to a reader of the release notes and accounted for 14 of the 34 words flagged by spelling::spell_check_package(). Remove them, keeping the references that do resolve for a reader: ADR-016 and ADR-017 (DECISIONS.md ships) and the GitHub reference #67. Spell check drops to 18 words, all real vocabulary, tracked in PUNY-ddljtzrv. Also ignore revdep/. revdepcheck::revdep_check() writes a SQLite db, a cloned library, and a full build of every reverse dependency there -- hundreds of MB, regenerated on demand. It was in neither .gitignore nor .Rbuildignore, so a local revdep run would dirty the tree and could reach a source tarball. Doc/config only; no R or C++ source touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cleanups surfaced by a
/cranpre-submission pass.NEWS.md: drop the 14
PUNY-xxxxxxxxslugsspelling::spell_check_package()flagged 34 words; 14 were Fiberplane issueslugs sitting in the user-facing changelog. They are internal tracker IDs, so
they are noise to a reader and noise to the spell checker at the same time.
Preserved the references that actually resolve for a reader: ADR-016 and
ADR-017 (
DECISIONS.mdships) and the GitHub reference #67.Spell check: 34 → 18 words. The remaining 18 are genuine technical
vocabulary and are handled separately in PUNY-ddljtzrv.
.gitignore/.Rbuildignore:revdep/revdepcheck::revdep_check()writes a SQLite db, a cloned library, and a fullbuild of every reverse dependency into
revdep/— hundreds of MB, regeneratedon demand. It was ignored by neither file, so a local revdep run would dirty the
working tree, and it could have been swept into a source tarball.
Verification
Doc/config only — no R or C++ source touched, so no clean rebuild or
R CMD checkgate applies.spell_check_package()re-run confirms 0 remainingslugs;
git check-ignoreconfirmsrevdep/is now covered;git ls-filesconfirms no build junk was ever tracked.
🤖 Generated with Claude Code