Force time localization with in-app navigation#5
Merged
Conversation
ladeak
commented
Mar 31, 2026
| <p class="mt-3 text-muted"> | ||
| Videos are streamed to the <a href="https://www.youtube.com/@@NETFoundation/streams">.NET Foundation YouTube channel</a>. | ||
| This calendar is available <a href="@CalendarService.Url">as an .ics file</a> you can add to your favorite calendar app. | ||
| </p> |
Contributor
Author
There was a problem hiding this comment.
I moved this as is to a js file, and added observeUrlChange to trigger it.
bartonjs
approved these changes
Mar 31, 2026
Owner
|
@ladeak The change is deployed. Changing the timezone on my phone and navigating forward/backward looks like it switches it back to "10:00", so if the fix works it doesn't work on iOS Safari 😦. |
Contributor
Author
|
I tried new from desktop chromium/Firefox, android (edge), and iPhone (safari/edge) and they looked good, I guess there is something more to it. |
Owner
|
Tried again today and my phone almost always behaved. The times that it left things saying 10:00 weren't predictable, but I also don't really anticipate people browsing more than one month forward or backward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schedule does not run the script for the local timezone calculation when navigating within the blazor app (I live in Europe):
See the behavior before (it shows 10:00 and 11:00 instead of 19:00 when doing in-app navigation - but if I open the schedule page directly, it shows the correct time)
BEFORE:
old.mp4
AFTER:
after.mp4
This is not perfect though, if I navigate with the buttons here:
the time is sometimes localized, sometimes not. This annoys me, but
Maybe @halter73 knows how to do this in a clean way? - I am open to refactor this PR.