Skip to content

Conversation

@cih9088
Copy link

@cih9088 cih9088 commented Jan 5, 2026

When the cache is stale, it fails to freshen the headers upon receiving a 304 response, resulting in re-validation for every subsequent request.

From https://www.rfc-editor.org/rfc/rfc9111.html#section-4.3.4

For each stored response identified, the cache MUST update its header fields with the header fields provided in the 304 (Not Modified) response, as per Section 3.2.

bartventer
bartventer previously approved these changes Jan 12, 2026
@bartventer bartventer self-requested a review January 12, 2026 15:53
@bartventer bartventer dismissed their stale review January 12, 2026 16:00

Dismissing my approval since the affected tests need to be updated to match the new logic. See my review comment for details.

The lint workflow failure is just pointing out some outdated file headers. I'll fix those before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants