Skip to content

fix: flashblock and block time settings#168

Open
meyer9 wants to merge 1 commit intomainfrom
meyer9/fix-block-time-setting
Open

fix: flashblock and block time settings#168
meyer9 wants to merge 1 commit intomainfrom
meyer9/fix-block-time-setting

Conversation

@meyer9
Copy link
Copy Markdown
Collaborator

@meyer9 meyer9 commented Feb 24, 2026

Description

Fixes flashblock and block time settings so the benchmark harness respects configurable block times instead of hardcoding 1-second blocks.

Changes

  • Configurable block time: Add top-level block_time field to BenchmarkConfig (parsed as a Go duration, default "1s"). Plumbed through ResolveTestRunsFromMatrixRunParams.BlockTime → consensus client and rollup config.
  • Configurable flashblocks block time: Add flashblocks.block_time config field (default "250ms"). Passed through RuntimeConfig to the builder client as --flashblocks.block-time.
  • Builder args: Pass --flashblocks.fixed, --flashblocks.block-time, and --rollup.chain-block-time to the builder binary.
  • Rollup config: GetRollupConfig now accepts blockTimeSec instead of hardcoding BlockTime: 1.
  • Sequencer benchmark: Sleep duration uses params.BlockTime instead of hardcoded 1000ms.
  • OP program benchmark: Passes blockTimeSec from params to NewOPProgramBenchmark.
  • CLI defaults: --root-dir defaults to ./data-dir and --output-dir defaults to ./output (no longer required flags).

Testing

  • go build ./... passes
  • go test ./... passes (matrix_test.go updated to use explicit 1 * time.Second)
  • Rebased onto main, conflicts resolved

@meyer9 meyer9 force-pushed the meyer9/improve-gas-estimation branch from 1ac186b to fc32ba8 Compare February 25, 2026 17:49
Base automatically changed from meyer9/improve-gas-estimation to main February 27, 2026 15:33
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Feb 27, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@meyer9 meyer9 force-pushed the meyer9/fix-block-time-setting branch from d9c7ce9 to 94daed8 Compare March 27, 2026 18:33
@meyer9 meyer9 marked this pull request as ready for review March 27, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants