Skip to content

Conversation

@jackchuma
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jan 8, 2026

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 8, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

@jackchuma jackchuma marked this pull request as ready for review January 9, 2026 00:11
@@ -0,0 +1,19 @@
OP_COMMIT=d6aa14e96fe5001b5c23c233d0747078d7ea02fb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,19 @@
OP_COMMIT=d6aa14e96fe5001b5c23c233d0747078d7ea02fb
BASE_CONTRACTS_COMMIT=51788f920e368e72c63cef24a5e1ea0f6562d9a5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is purposely not the most recent commit due to a compilation issue with the current commit

OP_COMMIT=d6aa14e96fe5001b5c23c233d0747078d7ea02fb
BASE_CONTRACTS_COMMIT=51788f920e368e72c63cef24a5e1ea0f6562d9a5

CANNON_ABSOLUTE_PRESTATE=0x033c000916b4a88cfffeceddd6cf0f4be3897a89195941e5a7c3f8209b4dbb6e
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BASE_CONTRACTS_COMMIT=51788f920e368e72c63cef24a5e1ea0f6562d9a5

CANNON_ABSOLUTE_PRESTATE=0x033c000916b4a88cfffeceddd6cf0f4be3897a89195941e5a7c3f8209b4dbb6e
CANNON_KONA_ABSOLUTE_PRESTATE=0x0323914d3050e80c3d09da528be54794fde60cd26849cd3410dde0da7cd7d4fa
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

function _postCheck(Vm.AccountAccess[] memory, Simulation.Payload memory) internal view override {
IOPContractsManagerStandardValidator.ValidationInputDev memory input =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ValidationInputDev since the usual ValidationInput does not include cannonKonaPrestate

@jackchuma jackchuma requested a review from xenoliss January 9, 2026 14:52
xenoliss
xenoliss previously approved these changes Jan 9, 2026
@cb-heimdall cb-heimdall dismissed xenoliss’s stale review January 13, 2026 22:15

Approved review 3644256005 from xenoliss is now dismissed due to new commit. Re-request for approval.

@jackchuma jackchuma merged commit e9e703e into main Jan 15, 2026
5 checks passed
@jackchuma jackchuma deleted the jack/sepolia-task branch January 15, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants