Skip to content
This repository was archived by the owner on Feb 12, 2026. It is now read-only.

chore: moves tips audit service to base/infra#21

Closed
mw2000 wants to merge 1 commit intomainfrom
mw2000/tips-audit
Closed

chore: moves tips audit service to base/infra#21
mw2000 wants to merge 1 commit intomainfrom
mw2000/tips-audit

Conversation

@mw2000
Copy link
Contributor

@mw2000 mw2000 commented Feb 3, 2026

We move the tips-audit service and associated crates from base/tips to base/infra.

Fixes #23

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 3, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@mw2000 mw2000 marked this pull request as draft February 3, 2026 22:19
@mw2000 mw2000 force-pushed the mw2000/tips-audit branch 3 times, most recently from 5b5e362 to 236e771 Compare February 4, 2026 07:42
@mw2000 mw2000 marked this pull request as ready for review February 4, 2026 07:50
@mw2000 mw2000 force-pushed the mw2000/tips-audit branch from 236e771 to 216707d Compare February 4, 2026 08:22
@mw2000 mw2000 requested a review from haardikk21 February 4, 2026 09:07
@mw2000 mw2000 force-pushed the mw2000/tips-audit branch 3 times, most recently from 3bca1cd to 0d1b35f Compare February 10, 2026 17:32
@mw2000 mw2000 requested review from danyalprout and removed request for haardikk21 February 10, 2026 17:47
Comment on lines +1 to +3
[package]
name = "utils"
description = "Shared utility functions for logging, metrics, and config parsing"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed tips-core to utils

@mw2000 mw2000 force-pushed the mw2000/tips-audit branch 2 times, most recently from a048a3a to 0960b25 Compare February 10, 2026 20:52
danyalprout
danyalprout previously approved these changes Feb 11, 2026
Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I wonder if we could do this and maintain the git history?

#[derive(Parser, Debug)]
#[command(author, version, about, long_about = None)]
struct Args {
#[arg(long, env = "TIPS_AUDIT_KAFKA_PROPERTIES_FILE")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, lets rename these env vars

We move the tips audit service and associated crates from base/tips to base/infra.
mw2000 pushed a commit that referenced this pull request Feb 12, 2026
* Rework the maintenance job to support flashblocks

* remove unused deps

* remove redundant clone
@mw2000 mw2000 marked this pull request as draft February 12, 2026 09:06
@mw2000
Copy link
Contributor Author

mw2000 commented Feb 12, 2026

looks good to me, I wonder if we could do this and maintain the git history?

Good idea.

Merge commit for git history and all changes from #21 #26 #27 moved to #20 since its easier to do history + all diffs in one PR as opposed to stacking it.

Moving current PRs to draft and reopening #20

#20.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move tips-audit to base/infra

3 participants