This repository was archived by the owner on Feb 12, 2026. It is now read-only.
fix(gobrr): close rate limiter semaphore on shutdown#45
Merged
danyalprout merged 1 commit intodanyal/p2p-testerfrom Feb 11, 2026
Merged
fix(gobrr): close rate limiter semaphore on shutdown#45danyalprout merged 1 commit intodanyal/p2p-testerfrom
danyalprout merged 1 commit intodanyal/p2p-testerfrom
Conversation
After shutdown, the replenisher stops adding permits but signers are blocked forever in acquire_rate_permit().await. Call limiter.close() so pending acquire_owned() calls return AcquireError, which the signer already handles gracefully by breaking out of its loop. Without this, all signers with target_tps configured deadlock on shutdown, waiting for permits that will never come.
mw2000
pushed a commit
that referenced
this pull request
Feb 12, 2026
Add TransactionResult and MeterBundleResponse types to support bundle execution metering with resource tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acquire_rate_permit().awaitlimiter.close()so pendingacquire_owned()calls returnAcquireError, which the signer already handles gracefullytarget_tpsconfigured deadlock on shutdown