This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Fix terminology mismatch Update send-eth.ts#6
Open
defitricks wants to merge 1 commit intobase:mainfrom
Open
Conversation
Fix terminology mismatch in error message for invalid signature type
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
In the provided script, the error message in the
elseblock reads:This is inconsistent with the rest of the script, where the term "signature type" is used. The mismatch can lead to confusion during debugging, as it does not align with the
--signature-typeargument or its intended meaning in the script.Solution:
Update the error message to correctly refer to "signature type":
Importance:
Changes Made:
Replaced:
With:
This ensures the error message reflects the correct context and matches the argument used in the script.