Conversation
|
Claude finished @hadashirt's task —— View job Code Review for PR #162SummaryThis PR correctly adds the missing Review Feedback✅ Code Quality and Best Practices
✅ Potential Bugs or Issues
✅ Performance Considerations
✅ Security Concerns
📝 Test Coverage
Additional Observations
Recommendation✅ Approve - This is a correct and necessary change that fixes type drift between the frontend SDK and backend API. The implementation is clean and follows best practices. Review Tasks:
|
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.26-pr.162.4daaf84Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.26-pr.162.4daaf84"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.26-pr.162.4daaf84"
}
}
Preview published to npm registry — try new features instantly! |
The backend ToolCall model includes "waiting_for_user_input" as a valid status value, but the SDK type was missing it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @hadashirt's task —— View job Code Review for PR #162SummaryThis PR correctly adds the missing Review Feedback✅ Code Quality and Best Practices
✅ Potential Bugs or Issues
✅ Performance Considerations
✅ Security Concerns
📝 Test Coverage
Additional Observations
Recommendation✅ Approve - This is a correct and necessary change that fixes type drift between the frontend SDK and backend API. The implementation is clean and follows best practices. Review Tasks:
|
Summary
"waiting_for_user_input"to thestatusunion inAgentMessageToolCallinagents.types.tsWhat drifted
The backend
ToolCallmodel inapper/backend/app/ai/models/message.pyhas:But the SDK type was missing
"waiting_for_user_input":Test plan
AgentMessageToolCall.statusincludes"waiting_for_user_input"in the TypeScript typenpm run create-docs-localto regenerate SDK docs (companion PR: base44-dev/mintlify-docs)🤖 Generated with Claude Code