Skip to content

Add 9 missing connector types to JSDoc table#164

Merged
wixysam merged 1 commit into
mainfrom
connector-types-fix
Apr 28, 2026
Merged

Add 9 missing connector types to JSDoc table#164
wixysam merged 1 commit into
mainfrom
connector-types-fix

Conversation

@hadashirt
Copy link
Copy Markdown
Contributor

Summary

  • Adds BambooHR, Calendly, Contentful, GitLab, Google Meet, Google Tasks, Hugging Face, Instagram, and Supabase to the available connectors table in ConnectorsModule JSDoc
  • Syncs the documented connector list with the full set of IntegrationType values supported in apper

Test plan

  • Verify all 9 new entries appear in the generated SDK docs table at developers/references/sdk/docs/interfaces/connectors.mdx after running npm run create-docs-local
  • Confirm alphabetical ordering is correct

🤖 Generated with Claude Code

Adds BambooHR, Calendly, Contentful, GitLab, Google Meet, Google Tasks, Hugging Face, Instagram, and Supabase to the available connectors table in ConnectorsModule JSDoc, syncing with the full list of supported integration types in apper.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented Apr 27, 2026

Claude finished @hadashirt's task —— View job


Code Review Complete ✅

I've reviewed PR #164 that adds 9 missing connector types to the JSDoc table. Here's my feedback:

Review Tasks

  • Read the modified file to understand the changes
  • Verify the new connector types are added correctly
  • Check alphabetical ordering
  • Assess code quality and best practices
  • Look for potential bugs or issues
  • Evaluate performance implications
  • Check for security concerns
  • Review test coverage

Code Quality and Best Practices ✅

The changes follow the established pattern perfectly:

  • Each new connector is added as a table row in the JSDoc comment
  • Proper formatting with | delimiters and backticks for type identifiers
  • Consistent naming convention using lowercase with underscores

Potential Bugs or Issues ✅

No bugs found. All 9 connectors are correctly added:

  1. BambooHR → bamboohr
  2. Calendly → calendly
  3. Contentful → contentful
  4. GitLab → gitlab
  5. Google Meet → googlemeet
  6. Google Tasks → googletasks
  7. Hugging Face → hugging_face
  8. Instagram → instagram
  9. Supabase → supabase

Alphabetical Ordering ✅

The entries maintain perfect alphabetical order within the table. Each new connector is inserted in the correct position relative to existing entries.

Performance Considerations ✅

No performance impact - these are JSDoc comment additions only, affecting documentation generation but not runtime behavior.

Security Concerns ✅

No security issues. The changes are purely documentation updates that list available connector types.

Test Coverage ⚠️

While the test plan mentions verifying documentation generation and alphabetical ordering, consider adding:

  • An automated test to ensure all IntegrationType values are documented in this table
  • A test that validates alphabetical ordering programmatically

Summary

This is a clean, well-executed PR that properly documents the new connector types. The changes are minimal, focused, and follow all existing conventions. Approved with the minor suggestion to consider automated tests for documentation completeness.

@github-actions
Copy link
Copy Markdown

🚀 Package Preview Available!


Install this PR's preview build with npm:

npm i @base44-preview/sdk@0.8.26-pr.164.f8d1b0e

Prefer not to change any import paths? Install using npm alias so your code still imports @base44/sdk:

npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.26-pr.164.f8d1b0e"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "@base44/sdk": "npm:@base44-preview/sdk@0.8.26-pr.164.f8d1b0e"
  }
}

Preview published to npm registry — try new features instantly!

@wixysam wixysam merged commit c559056 into main Apr 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants