Skip to content

Fix comment-typing freeze: scope drag-strum keydown + fix listener leak (#2926) #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitalibondar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix comment-typing freeze: scope drag-strum keydown + fix listener leak (#2926) #2929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfd4f94
Fix comment-typing freeze: scope drag-strum keydown, stop listener leak
vitalibondar Jun 7, 2026
70b17a7
Narrow editing-detection to text inputs; fall back to activeElement
vitalibondar Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions app/javascript/controllers/drag_and_strum_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,17 @@ export default class extends Controller {
connect() {
this.instrumentIndex = 0
this.preloadedAudioFiles = []
document.addEventListener("keydown", this.handleKeyDown.bind(this));
this.handleKeyDown = this.handleKeyDown.bind(this)
document.addEventListener("keydown", this.handleKeyDown);
}

disconnect() {
document.removeEventListener("keydown", this.handleKeyDown.bind(this));
document.removeEventListener("keydown", this.handleKeyDown);
}

handleKeyDown(event) {
if (this.#isEditingText(event.target)) { return }

if (event.shiftKey) {
this.instrumentIndex = this.#getInstrumentIndex(event)

Expand All @@ -66,6 +69,19 @@ export default class extends Controller {
}
}

#isEditingText(target) {
const element = target ?? document.activeElement
if (!element) { return false }
if (element.isContentEditable) { return true }
if (element.closest?.("textarea, select, lexxy-editor")) { return true }

const input = element.closest?.("input")
if (!input) { return false }

const NON_TEXT_INPUT_TYPES = [ "button", "submit", "reset", "checkbox", "radio", "file", "image", "range", "color" ]
return !NON_TEXT_INPUT_TYPES.includes((input.type || "text").toLowerCase())
}

dragEnter(event) {
event.preventDefault()
const container = this.#containerContaining(event.target)
Expand Down