Repository navigation
Fix yabeda-hotcell counting a call interrupted by an exception as ok - #108
Closed
flavorjones wants to merge 1 commit into
Closed
flavorjones wants to merge 1 commit into
flavorjones wants to merge 1 commit into
Conversation
When an exception, such as the application's own request timeout, escaped a call, `yabeda-hotcell` counted the call as `code="ok"` and recorded a `perform` of 0 seconds, inflating `ok` for the call's cell and operation. Count it under `code="exception"` and skip the `perform` observation. [Fix #93]
Member
Author
|
Superseded by #109. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When an exception escapes a call, such as the application's own request timeout, the
perform.hot_cellevent carriesexceptionand nocode.record_performfalls back to"ok"whenevercodeis missing, soyabeda-hotcellcounted the call ascode="ok"and recorded aperformof 0 seconds. Since #78 addedcellandoperationto that event, these calls are counted in theokseries of the call's real cell and operation.HotCell::LogSubscriberalready handles this case.Fixes #93
Details
record_performnow counts a call that carries an exception and no code undercode="exception", with an emptycause, and records noperformobservation, because the cell measured nothing. A call that the cell answered keeps its code.docs/observability.mddocuments the new code.