Repository navigation
Fix yabeda-hotcell recording 0 seconds for calls with no perform_ms - #113
Merged
Merged
Conversation
When the cell refused a call with `capacity`, or the client failed a call itself with `unavailable` or `timeout`, the response carried no `perform_ms`. `yabeda-hotcell` recorded those calls as 0-second `perform` observations, which pulled down the histogram's low percentiles. Record `perform` only when the response carries `perform_ms`. ref: #112
flavorjones
force-pushed
the
card-663-yabeda-failed-call-duration
branch
from
October 10, 2026 15:21
a79a62a to
f868336
Compare
flavorjones
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
yabeda-hotcellexportshotcell_perform_seconds, a histogram of how long a cell's worker spent running the operation for each call. The cell measures that time and returns it in the response asperform_ms.Some responses have no
perform_ms:capacity. The supervisor sends this answer with onlyqueued_ms, because no worker ran the operation.unavailablewhen it can't connect to the cell or read its answer, andtimeoutwhen it stops waiting. The client builds these responses with no timing.record_performrecorded these calls as 0-second observations. The histogram mixed those zeros with real perform times, which pulled its low percentiles down.This fixes the timing problem reported in #112.
Details
record_performrecords an observation only when the response hasperform_ms.requestsstill counts every call. Failures that come from a worker, such asunreadableorkilled, carry a measuredperform_msand are still recorded.