Repository navigation
Warn at boot when a cell runs another hotcell release - #90
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The warning is backward-compatible, safely handles untrusted values, and has focused behavioral coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Adds boot-time warnings for client/server release skew and corrects documentation about protocol compatibility.
Changes:
- Warns when
hotcell-clientandhotcell-serverversions differ. - Preserves compatibility with older cells and sanitizes untrusted version values.
- Adds integration/security tests and updates deployment guidance.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
README.md |
Documents the version-skew warning. |
CHANGELOG.md |
Records the new client warning. |
docs/DEPLOYMENT.md |
Clarifies release versus protocol skew. |
hotcell-client/lib/hot_cell/cell.rb |
Implements sanitized version-skew warnings. |
hotcell-client/lib/hot_cell/install/Gemfile.tt |
Corrects generated lockstep guidance. |
hotcell-client/test/integration_test.rb |
Tests matching, differing, and absent versions. |
hotcell-client/test/describe_survival_test.rb |
Tests protection against forged log lines. |
hotcell-client/test/install_test.rb |
Corrects the installer test explanation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
flavorjones
commented
Oct 1, 2026
flavorjones
commented
Oct 1, 2026
flavorjones
commented
Oct 1, 2026
flavorjones
commented
Oct 1, 2026
flavorjones
force-pushed
the
card-5278-cell-version-skew
branch
3 times, most recently
from
October 1, 2026 19:36
5e4ef80 to
0a90e75
Compare
`HotCell.describe_cells` did not compare a cell's `server_version` with the client's version. `docs/DEPLOYMENT.md` and the generated cell `Gemfile` said that a version skew answers `protocol` on every request, which is false. Warn at boot when the versions differ, and remove the false claim. [Fix #21]
flavorjones
force-pushed
the
card-5278-cell-version-skew
branch
from
October 1, 2026 19:36
0a90e75 to
2889a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since #73, a cell reports its
hotcell-serverversion asserver_versionin itshotcell.describeanswer.HotCell.describe_cellsdid not compare it with the client's version.docs/DEPLOYMENT.mdand the generatedGemfile.ttsaid that a version skew answersprotocolon every request. A cell answersprotocolonly to a differentPROTOCOL_VERSION(request.rb:29).Details
HotCell.describe_cellswarns when a cell'sserver_versiondiffers fromHotCell::Client::VERSION:A cell older than 0.6.0 reports no version, so its warning shows
nil. The warning escapes control characters in the version, so a cell cannot forge a log line.Remove the false claim from
docs/DEPLOYMENT.mdandGemfile.tt.Fixes #21